Skip to content

Commit f139355

Browse files
committed
bug: valgrind throws when importing into FileManager into Config
1 parent a83ddba commit f139355

File tree

3 files changed

+163
-28
lines changed

3 files changed

+163
-28
lines changed

src/boat/private/Config.nim

+1-4
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,7 @@ import std/[
2121
strutils,
2222
]
2323

24-
# TODO: simply importing FileManager causes valgrind to throw
25-
# ^ weird cuz nothing is in there but stubs
26-
import BoatErrors, BoatConstants
27-
24+
import BoatErrors, BoatConstants, FileManager
2825

2926
type Config* = ref object of RootObj
3027
use*: string ## \

src/boat/private/FileManager.nim

+3-2
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@
55

66
import ../../../bdd
77

8+
# valgrind throws if this file is imported into ./Config.nim
89
import std/[
9-
asyncdispatch,
10+
asyncdispatch, # causes valgrind to throw
1011
locks,
11-
threadpool,
12+
threadpool, # causes valgrind to throw
1213
]
1314

1415
import BoatConstants, BoatErrors

testresults.html

+159-22
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)