From 619504452a4c2276908cc23969039dcf03fb1c35 Mon Sep 17 00:00:00 2001
From: Nir Tamir <nirtamir2@gmail.com>
Date: Tue, 24 Sep 2024 12:22:31 +0300
Subject: [PATCH] sonarjs disables

---
 eslint.config.ts          |  1 -
 src/configs/javascript.ts | 13 ++++++++++++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/eslint.config.ts b/eslint.config.ts
index 6ec2dd8ca1..8c9d43d010 100644
--- a/eslint.config.ts
+++ b/eslint.config.ts
@@ -23,7 +23,6 @@ export default nirtamir2(
         "sonarjs/no-duplicate-string": "off",
         "sonarjs/no-gratuitous-expressions": "off",
         "sonarjs/no-nested-template-literals": "off",
-        "sonarjs/sonar-no-fallthrough": "off",
         "sonarjs/cognitive-complexity": "off",
         "sonarjs/no-nested-conditional": "off",
         "sonarjs/no-commented-code": "off",
diff --git a/src/configs/javascript.ts b/src/configs/javascript.ts
index b882b62046..3afa73c842 100644
--- a/src/configs/javascript.ts
+++ b/src/configs/javascript.ts
@@ -175,7 +175,7 @@ export async function javascript(
           { enforceForClassMembers: true, setWithoutGet: true },
         ],
 
-        'antfu/no-top-level-await': 'error',
+        "antfu/no-top-level-await": "error",
         "array-callback-return": "error",
         "block-scoped-var": "error",
         "constructor-super": "error",
@@ -411,6 +411,17 @@ export async function javascript(
     }),
     eslintPluginNoUseExtendNative.configs.recommended,
     sonarjs.configs.recommended,
+    {
+      name: "nirtami2/javascript/sonar/disables",
+      rules: {
+        "sonarjs/new-cap": "off", // sometimes I want api.GET()
+        "sonarjs/todo-tag": "off", // somtimes I want TODO: stuff
+
+        // Bugs in SonarJs
+        "sonarjs/sonar-no-fallthrough": "off", // error when using ESLint 9
+        "sonarjs/void-use": "off", // false positive on promises
+      },
+    },
     ...compat.extends("plugin:clsx/recommended"),
   ];
 }