Print observation with finish locale

This allows the jlink branch to demonstrate that not all locales are
available in java.base.

Author: Nicolai Parlog

monitor.persistence/src/main/java/monitor/persistence/StatisticsRepository.java

@@ -1,29 +1,39 @@
 package monitor.persistence;
 
 import monitor.statistics.Statistics;
+import monitor.statistics.Statistics.LivenessQuota;
 
+import java.text.NumberFormat;
 import java.util.Comparator;
+import java.util.Locale;
 import java.util.Map.Entry;
 import java.util.Optional;
 
 public class StatisticsRepository {
 
+	private final NumberFormat format = NumberFormat.getInstance(new Locale("fi", "FI"));
+
 	public Optional<Statistics> load() {
 		return Optional.empty();
 	}
 
 	public void store(Statistics statistics) {
-		System.out.printf("Total liveness: %s (from %d data points)%n",
-				statistics.totalLivenessQuota().livenessQuota(),
-				statistics.totalLivenessQuota().dataPointCount());
+		System.out.println("Total liveness: " + formatLiveness(statistics.totalLivenessQuota()));
 		statistics.livenessQuotaByService()
 				.sorted(Comparator.comparing(Entry::getKey))
-				.forEach(serviceLiveness ->
-				System.out.printf(" * %s liveness: %s (from %d data points)%n",
-						serviceLiveness.getKey(),
-						serviceLiveness.getValue().livenessQuota(),
-						serviceLiveness.getValue().dataPointCount()));
+				.map(serviceLiveness -> formatServiceLiveness(serviceLiveness.getKey(), serviceLiveness.getValue()))
+				.forEach(System.out::println);
 		System.out.println();
 	}
 
+	private String formatLiveness(LivenessQuota quota) {
+		return String.format("%s (from %s data points)",
+				format.format(quota.livenessQuota()),
+				format.format(quota.dataPointCount()));
+	}
+
+	private String formatServiceLiveness(String serviceName, LivenessQuota quota) {
+		return String.format(" * %s liveness: %s", serviceName, formatLiveness(quota));
+	}
+
 }

monitor.statistics/src/main/java/monitor/statistics/Statistician.java

@@ -2,12 +2,10 @@
 
 import monitor.observer.DiagnosticDataPoint;
 
-import java.util.stream.Stream;
-
 public class Statistician {
 
 	public Statistics emptyStatistics() {
-		return Statistics.create();
+		return Statistics.empty();
 	}
 
 	public Statistics compute(Statistics currentStats, Iterable<DiagnosticDataPoint> dataPoints) {

monitor.statistics/src/main/java/monitor/statistics/Statistics.java

@@ -21,7 +21,7 @@ public class Statistics {
 		this.livenessQuotaByService = requireNonNull(livenessQuotaByService);
 	}
 
-	static Statistics create() {
+	static Statistics empty() {
 		return new Statistics(LivenessQuota.zero(), new HashMap<>());
 	}
 

monitor/src/main/java/monitor/Monitor.java

@@ -31,10 +31,10 @@ public Monitor(
 	}
 
 	public void updateStatistics() {
-		List<DiagnosticDataPoint> newDataPoints = serviceObservers.stream()
+		List<DiagnosticDataPoint> newData = serviceObservers.stream()
 				.map(ServiceObserver::gatherDataFromService)
 				.collect(toList());
-		Statistics newStatistics = statistician.compute(currentStatistics, newDataPoints);
+		Statistics newStatistics = statistician.compute(currentStatistics, newData);
 		currentStatistics = newStatistics;
 		repository.store(newStatistics);
 	}