Skip to content

Commit 9d69bfd

Browse files
committedNov 3, 2019
better check for eof
1 parent 4734a5d commit 9d69bfd

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed
 

‎.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
language: node_js
22
node_js:
3-
- '6'
43
- '8'
54
- '10'
65
- '12'

‎index.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -70,11 +70,11 @@ class TextFileDiff extends EventEmitter {
7070
lineReader2.moveNext();
7171
}
7272

73-
// while both files has valid val
74-
while (lineReader1.val || lineReader2.val) {
73+
// while both files has valid val, check for actual false value
74+
while (lineReader1.val !== false || lineReader2.val !== false) {
7575
// forEach line in File1, compare to line in File2
76-
const line1 = lineReader1.val.toString(charset);
77-
const line2 = lineReader2.val.toString(charset);
76+
const line1 = lineReader1.val === false ? null : lineReader1.val.toString(charset);
77+
const line2 = lineReader2.val === false ? null : lineReader2.val.toString(charset);
7878
const cmp = compareFn(line1, line2);
7979

8080
// emit on compared

‎package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "text-file-diff",
3-
"version": "1.1.1",
3+
"version": "1.1.2",
44
"description": "line by line diff of two large files",
55
"license": "MIT",
66
"repository": "niiknow/text-file-diff",

0 commit comments

Comments
 (0)
Please sign in to comment.