Skip to content

Commit 199a83f

Browse files
committed
Modernize code and improve xml comments
1 parent af6c98b commit 199a83f

File tree

1 file changed

+12
-36
lines changed

1 file changed

+12
-36
lines changed

src/NHibernate/Dialect/SybaseASE16Dialect.cs

+12-36
Original file line numberDiff line numberDiff line change
@@ -20,53 +20,31 @@ namespace NHibernate.Dialect
2020
/// </remarks>
2121
public class SybaseASE16Dialect : SybaseASE15Dialect
2222
{
23-
#region Limit/offset support
24-
2523
/// <summary>
26-
/// Does this Dialect have some kind of <c>LIMIT</c> syntax?
24+
/// ASE 16 supports limit statements, see: https://help.sap.com/docs/SAP_ASE/e0d4539d39c34f52ae9ef822c2060077/26d84b4ddae94fed89d4e7c88bc8d1e6.html?locale=en-US
2725
/// </summary>
28-
/// <value>False, unless overridden.</value>
29-
public override bool SupportsLimit
30-
{
31-
get { return true; }
32-
}
26+
/// <returns>true</returns>
27+
public override bool SupportsLimit => true;
3328

34-
/// <summary>
35-
/// Does this Dialect support an offset?
36-
/// </summary>
37-
public override bool SupportsLimitOffset
38-
{
39-
get { return true; }
40-
}
29+
/// <inheritdoc />
30+
/// <returns>true</returns>
31+
public override bool SupportsLimitOffset => true;
4132

42-
/// <summary>
43-
/// Can parameters be used for a statement containing a LIMIT?
44-
/// </summary>
45-
public override bool SupportsVariableLimit
46-
{
47-
get { return false; }
48-
}
33+
/// <inheritdoc />
34+
/// <returns>false</returns>
35+
public override bool SupportsVariableLimit => false;
4936

50-
/// <summary>
51-
/// Attempts to add a <c>LIMIT</c> clause to the given SQL <c>SELECT</c>.
52-
/// Expects any database-specific offset and limit adjustments to have already been performed (ex. UseMaxForLimit, OffsetStartsAtOne).
53-
/// </summary>
54-
/// <param name="queryString">The <see cref="SqlString"/> to base the limit query off.</param>
55-
/// <param name="offset">Offset of the first row to be returned by the query. This may be represented as a parameter, a string literal, or a null value if no limit is requested. This should have already been adjusted to account for OffsetStartsAtOne.</param>
56-
/// <param name="limit">Maximum number of rows to be returned by the query. This may be represented as a parameter, a string literal, or a null value if no offset is requested. This should have already been adjusted to account for UseMaxForLimit.</param>
57-
/// <returns>A new <see cref="SqlString"/> that contains the <c>LIMIT</c> clause. Returns <c>null</c>
58-
/// if <paramref name="queryString"/> represents a SQL statement to which a limit clause cannot be added,
59-
/// for example when the query string is custom SQL invoking a stored procedure.</returns>
37+
/// <inheritdoc />
6038
public override SqlString GetLimitString(SqlString queryString, SqlString offset, SqlString limit)
6139
{
6240
if (offset == null && limit == null)
6341
return queryString;
6442

65-
SqlStringBuilder pagingBuilder = new SqlStringBuilder();
43+
var pagingBuilder = new SqlStringBuilder();
6644
pagingBuilder.Add(queryString);
6745
pagingBuilder.Add(" rows ");
6846

69-
if(limit !=null)
47+
if (limit != null)
7048
{
7149
pagingBuilder.Add(" limit ");
7250
pagingBuilder.Add(limit);
@@ -80,7 +58,5 @@ public override SqlString GetLimitString(SqlString queryString, SqlString offset
8058

8159
return pagingBuilder.ToSqlString();
8260
}
83-
84-
#endregion
8561
}
8662
}

0 commit comments

Comments
 (0)