Conventions regression

[jagregory]

See: https://groups.google.com/forum/#!topic/fluent-nhibernate/gs-wnmjiZ-M/discussion

Couldn't reproduce, but could be something to do with ExportTo being called first.

[MarkJPerry]

I came across the Convention problem today after upgrading to V1.3 from NuGet. I have included a small test project below which reproduces the issue. Some ideas that I had.found whilst debugging the source attempting to find the problem.

1.) The Apply/Accept methods in my "Convention" classes are simply not being called. They are being found however. Looks like perhaps you are missing a call to the Accept/Apply methods inside the convention classes themselves.
2.) In FluentMappingsContainer.cs line 139 it looks like you are "Merging" the conventions after writing the mappings which means anyone looking in the XML which is produced is not going to see their conventions applied.

If I have this totally wrong then apologies in advance just trying to help.

    public class AnsiStringConvention : IPropertyConvention, IPropertyConventionAcceptance
{
    public void Apply(IPropertyInstance instance)
    {
        instance.CustomType("AnsiString");
    }

    public void Accept(IAcceptanceCriteria<IPropertyInspector> criteria)
    {
        criteria.Expect(x => x.Type == typeof(string));
    }
}

public class AnsiStringIdConvention : IIdConvention, IIdConventionAcceptance
{
    public void Apply(IIdentityInstance instance)
    {
        instance.CustomType("AnsiString");
    }

    public void Accept(IAcceptanceCriteria<IIdentityInspector> criteria)
    {
        criteria.Expect(x => x.Type == typeof(string));
    }
}
public class User
{
    public virtual string Id { get; set; }
    public virtual string Name { get; set; }
}

public class UserMap : ClassMap<User>
{
    public UserMap()
    {
        Id(x => x.Id).GeneratedBy.Assigned();
        Map(x => x.Name).Length(50);
    }
}

public class ConventionTest
{
    [Test]
    public void Setup()
    {
        Fluently.Configure()
            .Database(MsSqlConfiguration.MsSql2000.ConnectionString(x=>x.FromConnectionStringWithKey("connstr")))
            .Mappings(m =>
                        {
                            m.FluentMappings
                                .AddFromAssemblyOf<ConventionTest>()
                                .Conventions.AddFromAssemblyOf<ConventionTest>()
                                .ExportTo("d:\\");
                        }).BuildSessionFactory();
    }
}

[MarkJPerry]

Further to my last comment. It does seem that moving line 139 : model.Conventions.Merge(conventionFinder); above the export mappings stuff to line 129 seems to fix the problem and all the tests pass.

This is also only an issue if you are exporting the mappings which I was doing in my test project.