Merge pull request #167 from ngrok/danielle/update-rust-docs

fix: Fix broken github pages deploy action

Author: Danielle Thomas

.github/workflows/docs.yml

@@ -15,12 +15,14 @@ jobs:
           profile: minimal
           toolchain: stable
           override: true
+
       - name: install protoc
         run: sudo apt-get -o Acquire::Retries=3 install -y protobuf-compiler
       - uses: actions-rs/cargo@v1
         with:
           command: doc
           args: --no-deps
+
       - name: Archive docs
         shell: sh
         run: |
@@ -35,39 +37,26 @@ jobs:
             --exclude=.git \
             --exclude=.github \
             .
-      - name: Upload artifact
-        uses: actions/upload-artifact@v4
+
+      - name: Upload static files as artifact
+        uses: actions/upload-pages-artifact@v3 # or specific "vX.X.X" version tag for this action
         with:
-          name: github-pages
-          path: ${{ runner.temp }}/artifact.tar
-          retention-days: 1
+          path:${{ runner.temp }}/artifact.tar
 
-  # Deploy job
+    # Deployment job
   deploy:
-    # Add a dependency to the build job
-    needs: build
-
     # Grant GITHUB_TOKEN the permissions required to make a Pages deployment
     permissions:
       pages: write      # to deploy to Pages
       id-token: write   # to verify the deployment originates from an appropriate source
 
-    # Deploy to the github-pages environment
     environment:
       name: github-pages
       url: ${{ steps.deployment.outputs.page_url }}
-
-    # Specify runner + deployment step
+      
     runs-on: ubuntu-latest
+    needs: build
     steps:
-      - name: Download artifact
-        uses: actions/download-artifact@v4
-        with:
-          name: github-pages
-          path: ./site
       - name: Deploy to GitHub Pages
         id: deployment
-        uses: actions/deploy-pages@v3
-        with:
-          artifact_name: github-pages
-          path: ./site
+        uses: actions/deploy-pages@v4