Skip to content

Commit a43ce23

Browse files
committed
ensure we aren't including/claiming to build any ARM v7 things
1 parent b896b97 commit a43ce23

File tree

4 files changed

+6
-35
lines changed

4 files changed

+6
-35
lines changed

.github/workflows/ci.yml

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -118,22 +118,17 @@ jobs:
118118
target: aarch64-linux-android
119119
if: ${{ github.ref == 'refs/heads/main' }}
120120
build: yarn build --target aarch64-linux-android
121-
# - host: ubuntu-latest
122-
# target: armv7-linux-androideabi
123-
# if: false
124-
# build: |
125-
# yarn build --target armv7-linux-androideabi
126121
- host: ubuntu-latest
127122
target: aarch64-unknown-linux-musl
128123
if: ${{ github.ref == 'refs/heads/main' }}
129124
docker: ghcr.io/napi-rs/napi-rs/nodejs-rust:lts-alpine
130125
build: |
131-
apk add clang18 llvm18
132-
ln -s /usr/lib/llvm-18/lib/libclang.so.1 /usr/lib/libclang.so
126+
apk add musl-dev gcc make cmake clang llvm build-base
133127
rustup target add aarch64-unknown-linux-musl
134-
export CC_aarch64_unknown_linux_musl=aarch64-linux-musl-gcc
135-
export CXX_aarch64_unknown_linux_musl=aarch64-linux-musl-g++
136-
export AR_aarch64_unknown_linux_musl=aarch64-linux-musl-ar
128+
export CARGO_BUILD_TARGET="aarch64-unknown-linux-musl"
129+
ln -s /usr/lib/gcc/aarch64-alpine-linux-musl/14.2.0/crtbeginS.o /usr/lib
130+
ln -s /usr/lib/gcc/aarch64-alpine-linux-musl/14.2.0/crtendS.o /usr/lib
131+
ln -s /usr/lib/gcc/aarch64-alpine-linux-musl/14.2.0/libgcc.a /usr/lib
137132
yarn build --target aarch64-unknown-linux-musl
138133
- host: windows-latest
139134
target: aarch64-pc-windows-msvc

npm/android-arm-eabi/README.md

Lines changed: 0 additions & 3 deletions
This file was deleted.

npm/android-arm-eabi/package.json

Lines changed: 0 additions & 20 deletions
This file was deleted.

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@ngrok/ngrok",
3-
"version": "1.5.0",
3+
"version": "1.5.1",
44
"main": "index.js",
55
"types": "index.d.ts",
66
"files": [
@@ -27,7 +27,6 @@
2727
"x86_64-unknown-linux-musl",
2828
"x86_64-unknown-freebsd",
2929
"i686-pc-windows-msvc",
30-
"armv7-linux-androideabi",
3130
"universal-apple-darwin"
3231
]
3332
}

0 commit comments

Comments
 (0)