Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responders in subpackage #45

Open
dgrijalva opened this issue Apr 9, 2013 · 3 comments
Open

Responders in subpackage #45

dgrijalva opened this issue Apr 9, 2013 · 3 comments

Comments

@dgrijalva
Copy link
Contributor

Scott, I think you're right that we should move most of the responders to a subpackage. I propose we keep SimpleResponse, StringResponse, ByteResponse, and PipeResponse in falcore proper and move all others to a new package, responder.

Thoughts?

@smw1218
Copy link
Contributor

smw1218 commented Apr 9, 2013

Sounds like a reasonable plan. The amount of code and docs for those responses is minimal so we can leave them where they are (or will be in the case of this repo)

@dgrijalva
Copy link
Contributor Author

I looked into adding template responders. Template is crazy complicated, though. I think users are better of using a PipeWriter and just doing the template stuff. I wonder what other responders we could include without overstepping. Maybe some built in error ones?

@smw1218
Copy link
Contributor

smw1218 commented Apr 11, 2013

Some simple error ones might be nice but I think most would just be simple 1-liners around StringResponse (with empty bodies). But it seems like a lot of the other "frameworks" provide such things so I guess we could too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants