Skip to content
This repository was archived by the owner on Aug 10, 2022. It is now read-only.

Commit 3977b27

Browse files
committed
build: remove go lint checks entirely
Go lint unapologetically provides to means to suppress lint warnings. Going forward this project will not use go lint for that reason.
1 parent 18c9b1e commit 3977b27

File tree

1 file changed

+1
-12
lines changed

1 file changed

+1
-12
lines changed

Makefile

Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,6 @@ $(BASE):
6868

6969
# Tools
7070

71-
GOLINT = $(BIN)/golint
72-
$(BIN)/golint:
73-
$(info $(M) building golint...)
74-
$Q go get -u golang.org/x/lint/golint
7571
GOLANGCILINT = $(BIN)/golangci-lint
7672
$(BIN)/golangci-lint:
7773
$(info $(M) building golangci-lint...)
@@ -149,13 +145,6 @@ test-coverage: test-coverage-tools | $(BASE) ; $(info $(M) running coverage test
149145
$Q $(GO) tool cover -html=$(COVERAGE_PROFILE) -o $(COVERAGE_HTML)
150146
$Q $(GOCOV) convert $(COVERAGE_PROFILE) | $(GOCOVXML) > $(COVERAGE_XML)
151147

152-
.PHONY: lint
153-
lint: $(GOLINT) ## Run golint check
154-
$(info $(M) running golint...) @
155-
@$(GOLINT) $(CURDIR)/app/... $(CURDIR)/lib/...
156-
157-
@find $(CURDIR)/plugins -mindepth 1 -maxdepth 1 -type d \
158-
-exec $(GOLINT) "{}/..." \;
159148
.PHONY: golangci-lint
160149
golangci-lint: deps $(GOLANGCILINT) ## Run golangci-lint check
161150
$(info $(M) running golangci-lint...) @
@@ -172,7 +161,7 @@ commitsar: $(COMMITSAR) ## Run git commit linter
172161
@ $(COMMITSAR)
173162

174163
.PHONY: all-linters
175-
all-linters: lint golangci-lint commitsar ## Run all linters
164+
all-linters: golangci-lint commitsar ## Run all linters
176165

177166
.PHONY: fmt
178167
fmt: ## Run source code formatter

0 commit comments

Comments
 (0)