Skip to content

Commit eaac6eb

Browse files
committed
Tests: adjusted LibreSSL certificate selection TODO with TLSv1.3.
LibreSSL 4.0 can select and send an RSA server certificate in TLSv1.3 without failing with "unknown pkey type" errors, when both RSA and ECC certificates are loaded. After certificate selection has occurred, it still always returns the most recently added certificate by SSL_get_certificate(), which means that OCSP stapling with multiple certificates remains broken here.
1 parent a5659ab commit eaac6eb

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

ssl_stapling.t

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -288,7 +288,8 @@ ok(!staple(8449, 'ECDSA'), 'ocsp error');
288288

289289
TODO: {
290290
local $TODO = 'broken TLSv1.3 sigalgs in LibreSSL'
291-
if $t->has_module('LibreSSL') && test_tls13();
291+
if $t->has_module('LibreSSL') && test_tls13()
292+
and not $t->has_feature('libressl:4.0.0');
292293

293294
like(`grep -F '[crit]' ${\($t->testdir())}/error.log`, qr/^$/s, 'no crit');
294295

stream_ssl_stapling.t

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,8 @@ ok(!staple(8449, 'ECDSA'), 'ocsp error');
287287

288288
TODO: {
289289
local $TODO = 'broken TLSv1.3 sigalgs in LibreSSL'
290-
if $t->has_module('LibreSSL') && test_tls13();
290+
if $t->has_module('LibreSSL') && test_tls13()
291+
and not $t->has_feature('libressl:4.0.0');
291292

292293
like(`grep -F '[crit]' ${\($t->testdir())}/error.log`, qr/^$/s, 'no crit');
293294

0 commit comments

Comments
 (0)