Skip to content

Commit cfdf4e8

Browse files
committed
Tests: removed quic_ciphers.t TODO, CCM cipher now supported.
While here, refined test comments.
1 parent 89bb4cd commit cfdf4e8

File tree

1 file changed

+5
-13
lines changed

1 file changed

+5
-13
lines changed

quic_ciphers.t

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -86,25 +86,17 @@ is(get("\x13\x03"), 'TLS_CHACHA20_POLY1305_SHA256',
8686

8787
is(get("\x13\x02\x13\x01"), 'TLS_AES_256_GCM_SHA384', 'ciphers many');
8888

89-
# prefer TLS_AES_128_CCM_SHA256 and fail gracefully as we are not there yet,
90-
# the cipher might be patched to be enabled by default in certain distributions
89+
# prefer TLS_AES_128_CCM_SHA256 with fallback to GCM,
90+
# the cipher is enabled by default in some distributions
9191

92-
my $s = Test::Nginx::HTTP3->new(8980, ciphers => "\x13\x04\x13\x01");
93-
94-
TODO: {
95-
todo_skip 'not yet', 1 unless $s;
96-
97-
like(get("\x13\x04\x13\x01", $s), qr/TLS_AES_128_[GC]CM_SHA256/,
92+
like(get("\x13\x04\x13\x01"), qr/TLS_AES_128_[GC]CM_SHA256/,
9893
'TLS_AES_128_CCM_SHA256');
9994

100-
}
101-
10295
###############################################################################
10396

10497
sub get {
105-
my ($ciphers, $sock) = @_;
106-
my $s = Test::Nginx::HTTP3->new(8980, ciphers => $ciphers,
107-
socket => $sock) or return;
98+
my ($ciphers) = @_;
99+
my $s = Test::Nginx::HTTP3->new(8980, ciphers => $ciphers);
108100
my $frames = $s->read(all => [{ sid => $s->new_stream(), fin => 1 }]);
109101

110102
my ($frame) = grep { $_->{type} eq "HEADERS" } @$frames;

0 commit comments

Comments
 (0)