Tests: removed TODO and try_run() checks for legacy versions.

Author: pluknet

access_log_escape.t

@@ -57,12 +57,7 @@ http_get('/?a="1 \\ ' . pack("n", 0x1b1c) . ' "&c=2');
 
 $t->stop();
 
-TODO: {
-local $TODO = 'not yet' unless $t->has_version('1.11.8');
-
 is($t->read_file('json.log'), '\"1 \\\\ \u001B\u001C \"2' . "\n", 'json');
 is($t->read_file('test.log'), '\x221 \x5C \x1B\x1C \x22-2' . "\n", 'default');
 
-}
-
 ###############################################################################

addition_buffered.t

@@ -62,11 +62,6 @@ $t->run();
 
 # if data is buffered, there should be no interleaved data in output
 
-TODO: {
-local $TODO = 'not yet' unless $t->has_version('1.11.5');
-
 like(http_get('/proxy/body.html'), qr/^XXXXXafter$/m, 'request');
 
-}
-
 ###############################################################################

auth_basic.t

@@ -95,17 +95,8 @@ like(http_get_auth('/', 'crypt2', '1'), qr!401 Unauthorized!,
 
 like(http_get_auth('/', 'apr1', 'password'), qr!SEETHIS!, 'apr1 md5');
 like(http_get_auth('/', 'plain', 'password'), qr!SEETHIS!, 'plain password');
-
-SKIP: {
-	# SHA1 may not be available unless we have OpenSSL
-
-	skip 'no sha1', 2 unless $t->has_module('--with-http_ssl_module')
-		or $t->has_module('--with-sha1')
-		or $t->has_module('--with-openssl');
-
-	like(http_get_auth('/', 'ssha', 'password'), qr!SEETHIS!, 'ssha');
-	like(http_get_auth('/', 'sha', 'password'), qr!SEETHIS!, 'sha');
-}
+like(http_get_auth('/', 'ssha', 'password'), qr!SEETHIS!, 'ssha');
+like(http_get_auth('/', 'sha', 'password'), qr!SEETHIS!, 'sha');
 
 unlike(http_get_auth('/', 'apr1', '123'), qr!SEETHIS!, 'apr1 md5 wrong');
 unlike(http_get_auth('/', 'plain', '123'), qr!SEETHIS!, 'plain wrong');

config_dump.t

@@ -77,15 +77,10 @@ like($dump, qr!^# configuration file $d/inc.conf:$!m, 'inc.conf found');
 like($dump, qr!^# configuration file $d/inc2.conf:$!m, 'inc2.conf found');
 like($dump, qr!^# configuration file $d/map.conf:$!m, 'map.conf found');
 
-TODO: {
-local $TODO = 'not yet' unless $t->has_version('1.11.6');
-
 unlike($dump, qr!(# configuration file $d/inc.conf:).*\1!s, 'inc.conf uniq');
 unlike($dump, qr!(# configuration file $d/inc2.conf:).*\1!s, 'inc2.conf uniq');
 unlike($dump, qr!(# configuration file $d/map.conf:).*\1!s, 'map.conf uniq');
 
-}
-
 is(getconf($t, $dump, 'nginx.conf'), $t->read_file('nginx.conf'), 'content');
 is(getconf($t, $dump, 'inc.conf'), $t->read_file('inc.conf'), 'content inc');
 is(getconf($t, $dump, 'map.conf'), $t->read_file('map.conf'), 'content inc 2');

geo.t

@@ -210,15 +210,9 @@ like($r, qr/^X-Del: world/m, 'geo delete');
 like($r, qr/^X-Ran: loopback/m, 'geo ranges');
 like($r, qr/^X-RIn: loopback/m, 'geo ranges include');
 
-TODO: {
-todo_skip 'use-after-free', 2 unless $ENV{TEST_NGINX_UNSAFE}
-	or $t->has_version('1.11.4');
-
 like(http_get('/2'), qr/^X-RDe: default/m, 'geo ranges delete');
 like(http_get('/2'), qr/^X-RD2: default/m, 'geo ranges delete 2');
 
-}
-
 like($r, qr/^X-ABe: loopback/m, 'geo ranges add before');
 like($r, qr/^X-AAf: loopback/m, 'geo ranges add after');
 like($r, qr/^X-Ins: loopback/m, 'geo ranges insert');
@@ -229,16 +223,9 @@ like(http_get('/1?ip=192.0.2.1'), qr/^X-Arg: test/m, 'geo from variable');
 like(http_get('/1?ip=10.0.0.1'), qr/^X-Arg: default/m, 'geo default');
 like(http_get('/1?ip=10.0.0.1'), qr/^X-ARa: default/m, 'geo ranges default');
 like(http_get('/1?ip=10.13.2.1'), qr/^X-ARa: foo2/m, 'geo ranges add');
-
-TODO: {
-todo_skip 'use-after-free', 1 unless $ENV{TEST_NGINX_UNSAFE}
-	or $t->has_version('1.11.4');
-
 like(http_get('/1?ip=10.11.2.1'), qr/^X-ARa: default/m,
 	'geo delete range from variable');
 
-}
-
 like(http_xff('192.0.2.1'), qr/^X-XFF: test/m, 'geo proxy');
 like(http_xff('10.0.0.1'), qr/^X-XFF: default/m, 'geo proxy default');
 like(http_xff('10.0.0.1, 192.0.2.1'), qr/^X-XFF: test/m, 'geo proxy long');

h2.t

@@ -1117,9 +1117,6 @@ undef $grace4;
 
 # GOAWAY without awaiting active streams, further streams ignored
 
-TODO: {
-local $TODO = 'not yet' unless $t->has_version('1.11.6');
-
 $s = Test::Nginx::HTTP2->new(port(8080));
 $sid = $s->new_stream({ path => '/t1.html' });
 $s->read(all => [{ sid => $sid, length => 2**16 - 1 }]);
@@ -1137,8 +1134,6 @@ $frames = $s->read(all => [{ sid => $sid2, fin => 0x4 }], wait => 0.5);
 ($frame) = grep { $_->{type} eq 'HEADERS' } @$frames;
 is($frame, undef, 'GOAWAY with active stream - no new stream');
 
-}
-
 $s->h2_window(100, $sid);
 $s->h2_window(100);
 $frames = $s->read(all => [{ sid => $sid, fin => 0x1 }]);

h2_auth_request.t

@@ -72,10 +72,6 @@ $t->run();
 
 my ($s, $sid, $frames, $frame);
 
-TODO: {
-todo_skip 'use-after-free', 2 unless $ENV{TEST_NGINX_UNSAFE}
-	or $t->has_version('1.11.7');
-
 # second stream is used to induce body corruption issue
 
 $s = Test::Nginx::HTTP2->new();
@@ -87,6 +83,4 @@ $frames = $s->read(all => [{ sid => $sid, fin => 1 }]);
 is($frame->{headers}->{'x-body'}, 'A' x 600, 'auth request body');
 isnt($frame->{headers}->{'x-body-file'}, undef, 'auth request body file');
 
-}
-
 ###############################################################################

h2_fastcgi_request_buffering.t

@@ -53,18 +53,13 @@ http {
 EOF
 
 $t->run();
-
-my $f = get_body('/chunked');
-plan(skip_all => 'no unbuffered request body') unless $f;
-$f->{http_end}();
-
 $t->plan(48);
 
 ###############################################################################
 
 # unbuffered request body to fastcgi
 
-$f = get_body('/');
+my $f = get_body('/');
 ok($f->{headers}, 'request');
 is($f->{upload}('01234', body_more => 1), '01234', 'part');
 is($f->{upload}('56789'), '56789_eos', 'part 2');

h2_max_requests.t

@@ -49,7 +49,7 @@ http {
 EOF
 
 $t->write_file('index.html', '');
-$t->try_run('no http2_max_requests')->plan(5);
+$t->run()->plan(5);
 
 ###############################################################################
 

h2_proxy_request_buffering.t

@@ -66,18 +66,13 @@ http {
 EOF
 
 $t->run();
-
-my $f = get_body('/chunked');
-plan(skip_all => 'no unbuffered request body') unless $f;
-$f->{http_end}();
-
 $t->plan(49);
 
 ###############################################################################
 
 # unbuffered request body
 
-$f = get_body('/', 'content-length' => 10);
+my $f = get_body('/', 'content-length' => 10);
 ok($f->{headers}, 'request');
 is($f->{upload}('01234', body_more => 1), '01234', 'part');
 is($f->{upload}('56789'), '56789', 'part 2');