Skip to content

Commit 664f4cb

Browse files
committed
Tests: unbreak tests with dynamic certificates on stable.
In 74cffa9d4c43, ticket based session reuse is enabled in addition to using a shared SSL session cache. This changed how a session can be resumed in a different server: - for a session ID based resumption, it is resumed in the same context - when using session tickets, a key name is also checked for matching - with a ticket callback, this is skipped in favor of callback's logic This makes 'session id context match' tests fail with session tickets on stable since ticket key names are unique in distinct SSL contexts. On the other hand, tests pass on 1.23.2+ due to automatic ticket keys rotation that installs ticket callback, and using a common shared SSL session cache.
1 parent 4521150 commit 664f4cb

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

ssl_certificate.t

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,15 @@ my ($s, $ssl) = get('default', 8080);
184184
my $ses = Net::SSLeay::get_session($ssl);
185185

186186
like(get('default', 8080, $ses), qr/default:r/, 'session reused');
187+
188+
TODO: {
189+
# ticket key name mismatch prevents session resumption
190+
local $TODO = 'not yet' unless $t->has_version('1.23.2');
191+
187192
like(get('default', 8081, $ses), qr/default:r/, 'session id context match');
193+
194+
}
195+
188196
like(get('default', 8082, $ses), qr/default:\./, 'session id context distinct');
189197

190198
# errors

stream_ssl_certificate.t

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,15 @@ my ($s, $ssl) = get('default', 8080);
161161
my $ses = Net::SSLeay::get_session($ssl);
162162

163163
like(get('default', 8080, $ses), qr/default:r/, 'session reused');
164+
165+
TODO: {
166+
# ticket key name mismatch prevents session resumption
167+
local $TODO = 'not yet' unless $t->has_version('1.23.2');
168+
164169
like(get('default', 8081, $ses), qr/default:r/, 'session id context match');
170+
171+
}
172+
165173
like(get('default', 8082, $ses), qr/default:\./, 'session id context distinct');
166174

167175
# errors

0 commit comments

Comments
 (0)