Skip to content

Commit 22478cd

Browse files
committed
Tests: removed old "Net::SSLeay version >= 1.36" checks.
Net::SSLeay of such ancient versions, as checked in ssl_verify_client tests, predates SNI support and requires OpenSSL 0.9.8 to run. Also, a more recent Net::SSLeay is required for IO::Socket::SSL >= 1.954. This makes it difficult to figure out whether checks actually work, so they were removed for simplicity.
1 parent 345f9b7 commit 22478cd

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

ssl_verify_client.t

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,17 +152,13 @@ like(get('localhost', '2.example.com'), qr/SUCCESS.*BEGIN/, 'good cert');
152152
like(get('optional', '2.example.com'), qr/SUCCESS.*BEGI/, 'good cert optional');
153153
like(get('optional', '3.example.com'), qr/SUCCESS.*BEGIN/, 'good cert trusted');
154154

155-
SKIP: {
156-
skip 'Net::SSLeay version >= 1.36 required', 1 if $Net::SSLeay::VERSION < 1.36;
157-
158155
TODO: {
159156
local $TODO = 'broken TLSv1.3 CA list in LibreSSL'
160157
if $t->has_module('LibreSSL') && test_tls13();
161158

162159
my $ca = join ' ', get('optional', '3.example.com');
163160
is($ca, '/CN=2.example.com', 'no trusted sent');
164161

165-
}
166162
}
167163

168164
like(get('optional', undef, 'localhost'), qr/421 Misdirected/, 'misdirected');

stream_ssl_verify_client.t

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,17 +120,13 @@ like(get(8081, '2.example.com'), qr/SUCCESS.*BEGIN/, 'good cert');
120120
like(get(8082, '2.example.com'), qr/SUCCESS.*BEGIN/, 'good cert optional');
121121
like(get(8082, '3.example.com'), qr/SUCCESS.*BEGIN/, 'good cert trusted');
122122

123-
SKIP: {
124-
skip 'Net::SSLeay version >= 1.36 required', 1 if $Net::SSLeay::VERSION < 1.36;
125-
126123
TODO: {
127124
local $TODO = 'broken TLSv1.3 CA list in LibreSSL'
128125
if $t->has_module('LibreSSL') && test_tls13();
129126

130127
my $ca = join ' ', get(8082, '3.example.com');
131128
is($ca, '/CN=2.example.com', 'no trusted sent');
132129

133-
}
134130
}
135131

136132
$t->stop();

0 commit comments

Comments
 (0)