Adding logging to framework methodes

Author: tataruty

tests/framework/generate_manifests.go

@@ -7,7 +7,6 @@ import (
 	"io"
 	"text/template"
 
-	. "github.com/onsi/ginkgo/v2"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/util/yaml"
 	"sigs.k8s.io/controller-runtime/pkg/client"
@@ -222,7 +221,6 @@ func GenerateScaleListenerObjects(numListeners int, tls bool) (ScaleObjects, err
 }
 
 func generateSecrets(secrets []string) ([]client.Object, error) {
-	GinkgoWriter.Printf("Generating secrets\n")
 	objects := make([]client.Object, 0, len(secrets))
 
 	for _, secret := range secrets {
@@ -239,7 +237,6 @@ func generateSecrets(secrets []string) ([]client.Object, error) {
 
 		objects = append(objects, objs...)
 	}
-	GinkgoWriter.Printf("Generated %d secrets\n", len(objects))
 
 	return objects, nil
 }

tests/framework/ngf.go

@@ -102,8 +102,6 @@ func InstallNGF(cfg InstallationConfig, extraArgs ...string) ([]byte, error) {
 
 // CreateLicenseSecret creates the NGINX Plus JWT secret.
 func CreateLicenseSecret(k8sClient client.Client, namespace, filename string) error {
-	GinkgoWriter.Printf("Creating NGINX Plus license secret in namespace %q from file %q\n", namespace, filename)
-
 	conf, err := os.ReadFile(filename)
 	if err != nil {
 		readFileErr := fmt.Errorf("error reading file %q: %w", filename, err)

tests/suite/advanced_routing_test.go

@@ -119,6 +119,8 @@ func expectRequestToRespondFromExpectedServer(
 	GinkgoWriter.Printf("Expecting request to respond from the server %q\n", expServerName)
 	status, body, err := framework.Get(appURL, address, timeoutConfig.RequestTimeout, headers, queryParams)
 	if err != nil {
+		GinkgoWriter.Printf("ERROR making GET request to %q: %v\n", appURL, err)
+
 		return err
 	}
 

tests/suite/system_suite_test.go

@@ -237,6 +237,7 @@ func createNGFInstallConfig(cfg setupConfig, extraInstallArgs ...string) framewo
 		installCfg.NgfImageRepository = *ngfImageRepository
 		installCfg.NginxImageRepository = *nginxImageRepository
 		if *plusEnabled && cfg.nfr {
+			GinkgoWriter.Printf("Using NGINX Plus image repository %q\n", *nginxPlusImageRepository)
 			installCfg.NginxImageRepository = *nginxPlusImageRepository
 		}
 		installCfg.ImageTag = *imageTag
@@ -246,9 +247,11 @@ func createNGFInstallConfig(cfg setupConfig, extraInstallArgs ...string) framewo
 		chartVersion = "0.0.0-edge"
 		installCfg.ChartVersion = chartVersion
 		if *plusEnabled && cfg.nfr {
+			GinkgoWriter.Printf("Using NGINX Plus image repository %q\n", *nginxPlusImageRepository)
 			installCfg.NginxImageRepository = fmt.Sprintf(formatNginxPlusEdgeImagePath, *gkeProject)
 		}
 	case *plusEnabled && cfg.nfr:
+		GinkgoWriter.Printf("Using NGINX Plus image repository %q\n", *nginxPlusImageRepository)
 		installCfg.NginxImageRepository = fmt.Sprintf(formatNginxPlusEdgeImagePath, *gkeProject)
 	}