Skip to content

spurious build failures #26

Open
Open
@ryepup

Description

@ryepup

Describe the bug

When dependabot updates a devDependency, our workflows are trying to release a new version of the reference-lib package. This fails:

$ npm publish
npm notice 
npm notice 📦  @nginxinc/[email protected]
npm notice === Tarball Contents === 
npm notice 668B  README.md      
npm notice 8[9](https://github.com/nginxinc/nginx-directive-reference/actions/runs/6110721544/job/16584389628#step:8:10)9B  dist/index.d.ts
npm notice 1.4MB dist/index.js  
npm notice 635B  package.json   
npm notice === Tarball Details === 
npm notice name:          @nginxinc/reference-lib                 
npm notice version:       1.0.3                                   
npm notice filename:      @nginxinc/reference-lib-1.0.3.tgz       
npm notice package size:  206.8 kB                                
npm notice unpacked size: 1.4 MB                                  
npm notice shasum:        ff2e1e5b40ce3f1c139e3348c4f70a326f1f15f3
npm notice integrity:     sha5[12](https://github.com/nginxinc/nginx-directive-reference/actions/runs/6110721544/job/16584389628#step:8:13)-[14](https://github.com/nginxinc/nginx-directive-reference/actions/runs/6110721544/job/16584389628#step:8:15)Nn6bKn0FTyp[...]1iMWjahQ5gBlw==
npm notice total files:   4                                       
npm notice 
npm notice Publishing to https://npm.pkg.github.com/
npm ERR! code EPUBLISHCONFLICT
npm ERR! publish fail Cannot publish over existing version.
npm ERR! publish fail Update the 'version' field in package.json and try again.
npm ERR! publish fail 
npm ERR! publish fail To automatically increment version numbers, see:
npm ERR! publish fail     npm help version

Example job: https://github.com/nginxinc/nginx-directive-reference/actions/runs/6110721544/job/16584389628

To reproduce

Steps to reproduce the behavior:

  1. merge a change to reference-lib without bumping the version number in package.json
  2. See error

Expected behavior

The CI does not attempt to publish if nothing relevant has changed (i.e. devDependency change)

Your environment

github CI workers

Additional context

It's possible that a devDependency change might be something we want to release as a new reference-lib npm package, if something in rollup changed, but that seems unlikely with how simple this library is.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions