|
| 1 | +# Contributing Guidelines |
| 2 | + |
| 3 | +The following is a set of guidelines for contributing to the Docker NGINX image. We really appreciate that you are considering contributing! |
| 4 | + |
| 5 | +#### Table Of Contents |
| 6 | + |
| 7 | +[Getting Started](#getting-started) |
| 8 | + |
| 9 | +[Contributing](#contributing) |
| 10 | + |
| 11 | +[Code Guidelines](#code-guidelines) |
| 12 | + |
| 13 | +[Code of Conduct](https://github.com/nginxinc/docker-nginx/blob/master/CODE_OF_CONDUCT.md) |
| 14 | + |
| 15 | +## Getting Started |
| 16 | + |
| 17 | +Follow our [how to use this image guide](https://hub.docker.com/_/nginx/) to get the Docker NGINX image up and running. |
| 18 | + |
| 19 | +## Contributing |
| 20 | + |
| 21 | +### Report a Bug |
| 22 | + |
| 23 | +To report a bug, open an issue on GitHub with the label `bug` using the available bug report issue template. Please ensure the bug has not already been reported. **If the bug is a potential security vulnerability, please report it using our [security policy](https://github.com/nginxinc/docker-nginx/blob/master/SECURITY.md).** |
| 24 | + |
| 25 | +### Suggest a Feature or Enhancement |
| 26 | + |
| 27 | +To suggest a feature or enhancement, please create an issue on GitHub with the label `enhancement` using the available [feature request template](https://github.com/nginxinc/docker-nginx/blob/master/.github/feature_request_template.md). Please ensure the feature or enhancement has not already been suggested. |
| 28 | + |
| 29 | +### Open a Pull Request |
| 30 | + |
| 31 | +- Fork the repo, create a branch, implement your changes, add any relevant tests, submit a PR when your changes are **tested** and ready for review. |
| 32 | +- Fill in [our pull request template](https://github.com/nginxinc/docker-nginx/blob/master/.github/pull_request_template.md). |
| 33 | + |
| 34 | +Note: if you'd like to implement a new feature, please consider creating a [feature request issue](https://github.com/nginxinc/docker-nginx/blob/master/.github/feature_request_template.md) first to start a discussion about the feature. |
| 35 | + |
| 36 | +## Code Guidelines |
| 37 | + |
| 38 | +### Git Guidelines |
| 39 | + |
| 40 | +- Keep a clean, concise and meaningful git commit history on your branch (within reason), rebasing locally and squashing before submitting a PR. |
| 41 | +- If possible and/or relevant, use the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) format when writing a commit message, so that changelogs can be automatically generated |
| 42 | +- Follow the guidelines of writing a good commit message as described here <https://chris.beams.io/posts/git-commit/> and summarised in the next few points: |
| 43 | + - In the subject line, use the present tense ("Add feature" not "Added feature"). |
| 44 | + - In the subject line, use the imperative mood ("Move cursor to..." not "Moves cursor to..."). |
| 45 | + - Limit the subject line to 72 characters or less. |
| 46 | + - Reference issues and pull requests liberally after the subject line. |
| 47 | + - Add more detailed description in the body of the git message (`git commit -a` to give you more space and time in your text editor to write a good message instead of `git commit -am`). |
| 48 | + |
| 49 | +### Docker Guidelines |
| 50 | + |
| 51 | +- Update any entrypoint scripts via the the scripts contained in the `/entrypoint` directory. |
| 52 | +- Update any Dockerfiles via the Dockerfile templates in the root directory (e.g. `Dockerfile-alpine.template`). |
| 53 | +- Run the `./update.sh` script to apply all entrypoint/Dockerfile template changes to the relevant image entrypoints & Dockerfiles. |
0 commit comments