Skip to content

Commit 23109d2

Browse files
committed
Pin rake version ~>11.1 to support last_comment
- rspec-rails 3.3.x is pinned by Payola's Rails 4.1 Gemfile - rspec-rails 3.3.x uses Rake's `last_comment` method - Rake 12 removes the `last_comment` method (replacing it with `last_description`) so rake version < 12 is needed for the Rails 4.1 Payola build. An alternative fix would have been to unpin rspec-rails or at least set it to rspec-rails 3.4.x as rspec-rails 3.4.x does not use Rake's `last_comment` method. However, the Payola Rails 4.1 build breaks with rspec-rails 3.4.x as rspec-rails tries to load activejob which is not available in Rails 4.1. This new issue could be fixed by avoiding defining the `::ActiveJob` constant unless activejob is supported. Checking for `::ActiveJob` is how rspec-rails 3.4.x decides if to load the activejob gem. Currently Payola always defines `::ActiveJob`.
1 parent e8b97f2 commit 23109d2

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

gemfiles/rails_4_1.gemfile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,4 @@ end
1010
gem 'rspec_junit_formatter'
1111

1212
gem 'rails', git: 'https://github.com/rails/rails', branch: '4-1-stable'
13+
gem 'rake', '~> 11.1'

0 commit comments

Comments
 (0)