Skip to content

Commit cb84667

Browse files
author
FelixAbrahamsson
committed
fix: rename new_columns to with_colummns
1 parent fbf5e47 commit cb84667

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

datastream/dataset.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ def group_split(
330330
}
331331

332332

333-
def new_columns(
333+
def with_columns(
334334
self: Dataset[T], **kwargs: Callable[pd.Dataframe, pd.Series]
335335
) -> Dataset[T]:
336336
'''
@@ -340,7 +340,7 @@ def new_columns(
340340
341341
>>> (
342342
... Dataset.from_dataframe(pd.DataFrame(dict(number=[1, 2, 3])))
343-
... .new_columns(twice=lambda df: df['number'] * 2)
343+
... .with_columns(twice=lambda df: df['number'] * 2)
344344
... .map(lambda row: row['twice'])
345345
... )[-1]
346346
6
@@ -576,15 +576,15 @@ def test_subset():
576576
assert dataset[0]['number'] == numbers[2]
577577

578578

579-
def test_new_columns():
579+
def test_with_columns():
580580
from pytest import raises
581581

582582
with raises(ValueError):
583583
dataset = (
584584
Dataset.from_dataframe(pd.DataFrame(dict(
585585
key=np.arange(100),
586586
)))
587-
.new_columns(key=lambda df: df['key'] * 2)
587+
.with_columns(key=lambda df: df['key'] * 2)
588588
)
589589

590590

0 commit comments

Comments
 (0)