[nextest-runner] always close stdin before running tests

Some tests might accidentally read from standard input. Always close it.

Author: sunshowers

cargo-nextest/src/tests_integration/fixtures.rs

@@ -61,6 +61,7 @@ pub static EXPECTED_LIST: Lazy<Vec<TestInfo>> = Lazy::new(|| {
                 ("test_result_failure", false),
                 ("test_slow_timeout", true),
                 ("test_slow_timeout_2", true),
+                ("test_stdin_closed", false),
                 ("test_subprocess_doesnt_exit", false),
                 ("test_success", false),
                 ("test_success_should_panic", false),
@@ -302,6 +303,7 @@ pub fn check_run_output(stderr: &[u8], relocated: bool) {
         (false, "nextest-tests::basic test_result_failure"),
         (true, "nextest-tests::basic test_success_should_panic"),
         (false, "nextest-tests::basic test_failure_assert"),
+        (true, "nextest-tests::basic test_stdin_closed"),
         (false, "nextest-tests::basic test_flaky_mod_6"),
         (cwd_pass, "nextest-tests::basic test_cwd"),
         (
@@ -325,10 +327,10 @@ pub fn check_run_output(stderr: &[u8], relocated: bool) {
     }
 
     let summary_reg = if relocated {
-        Regex::new(r"Summary \[.*\] *25 tests run: 17 passed \(1 leaky\), 8 failed, 4 skipped")
+        Regex::new(r"Summary \[.*\] *26 tests run: 18 passed \(1 leaky\), 8 failed, 4 skipped")
             .unwrap()
     } else {
-        Regex::new(r"Summary \[.*\] *25 tests run: 18 passed \(1 leaky\), 7 failed, 4 skipped")
+        Regex::new(r"Summary \[.*\] *26 tests run: 19 passed \(1 leaky\), 7 failed, 4 skipped")
             .unwrap()
     };
     assert!(

fixtures/nextest-tests/tests/basic.rs

@@ -1,5 +1,5 @@
 // Copyright (c) The nextest Contributors
-use std::{env, path::Path};
+use std::{env, io::Read, path::Path};
 
 #[test]
 fn test_success() {}
@@ -201,3 +201,15 @@ fn sleep_cmd(secs: usize) -> std::process::Command {
     cmd.arg(&format!("{secs}"));
     cmd
 }
+
+#[test]
+fn test_stdin_closed() {
+    let mut buf = [0u8; 8];
+    // This should succeed with 0 because it's attached to /dev/null or its Windows equivalent.
+    assert_eq!(
+        0,
+        std::io::stdin()
+            .read(&mut buf)
+            .expect("reading from /dev/null succeeded")
+    );
+}

nextest-runner/src/runner.rs

@@ -23,6 +23,7 @@ use std::{
     convert::Infallible,
     marker::PhantomData,
     num::NonZeroUsize,
+    process::Stdio,
     sync::{
         atomic::{AtomicBool, Ordering},
         Arc,
@@ -413,6 +414,7 @@ impl<'a> TestRunnerInner<'a> {
 
         // Debug environment variable for testing.
         cmd.env("__NEXTEST_ATTEMPT", format!("{}", attempt));
+        cmd.stdin(Stdio::null());
 
         if !self.no_capture {
             // Capture stdout and stderr.

nextest-runner/tests/integration/fixtures.rs

@@ -116,6 +116,7 @@ pub(crate) static EXPECTED_TESTS: Lazy<BTreeMap<&'static str, Vec<TestFixture>>>
                 TestFixture { name: "test_result_failure", status: FixtureStatus::Fail },
                 TestFixture { name: "test_slow_timeout", status: FixtureStatus::IgnoredPass },
                 TestFixture { name: "test_slow_timeout_2", status: FixtureStatus::IgnoredPass },
+                TestFixture { name: "test_stdin_closed", status: FixtureStatus::Pass },
                 TestFixture { name: "test_subprocess_doesnt_exit", status: FixtureStatus::Leak },
                 TestFixture { name: "test_success", status: FixtureStatus::Pass },
                 TestFixture { name: "test_success_should_panic", status: FixtureStatus::Pass },