Skip to content

Commit d77005e

Browse files
Show quota error
Test for quota on server Signed-off-by: tobiasKaminsky <[email protected]>
1 parent 1a8f70e commit d77005e

File tree

7 files changed

+15
-7
lines changed

7 files changed

+15
-7
lines changed

Diff for: app/src/main/java/com/nextcloud/client/jobs/BackgroundJobFactory.kt

-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import androidx.work.WorkerFactory
3030
import androidx.work.WorkerParameters
3131
import com.nextcloud.client.account.UserAccountManager
3232
import com.nextcloud.client.core.Clock
33-
import com.nextcloud.client.device.DeviceInfo
3433
import com.nextcloud.client.device.PowerManagementService
3534
import com.nextcloud.client.documentscan.GeneratePDFUseCase
3635
import com.nextcloud.client.documentscan.GeneratePdfFromImagesWork
@@ -59,7 +58,6 @@ class BackgroundJobFactory @Inject constructor(
5958
private val clock: Clock,
6059
private val powerManagementService: PowerManagementService,
6160
private val backgroundJobManager: Provider<BackgroundJobManager>,
62-
private val deviceInfo: DeviceInfo,
6361
private val accountManager: UserAccountManager,
6462
private val resources: Resources,
6563
private val dataProvider: ArbitraryDataProvider,

Diff for: app/src/main/java/com/owncloud/android/datamodel/UploadsStorageManager.java

+4-2
Original file line numberDiff line numberDiff line change
@@ -204,7 +204,9 @@ private int updateUploadInternal(Cursor c, UploadStatus status, UploadResult res
204204
+ upload.toFormattedString() + ")");
205205

206206
upload.setUploadStatus(status);
207-
upload.setLastResult(result);
207+
if (result != null) {
208+
upload.setLastResult(result);
209+
}
208210
upload.setRemotePath(remotePath);
209211
if (localPath != null) {
210212
upload.setLocalPath(localPath);
@@ -687,7 +689,7 @@ public void updateDatabaseUploadStart(UploadFileOperation upload) {
687689
updateUploadStatus(
688690
upload.getOCUploadId(),
689691
UploadStatus.UPLOAD_IN_PROGRESS,
690-
UploadResult.UNKNOWN,
692+
null,
691693
upload.getRemotePath(),
692694
localPath
693695
);

Diff for: app/src/main/java/com/owncloud/android/db/OCUpload.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ public void setDataFixed(FileUploader.FileUploaderBinder binder) {
196196
*/
197197
public void setUploadStatus(UploadStatus uploadStatus) {
198198
this.uploadStatus = uploadStatus;
199-
setLastResult(UploadResult.UNKNOWN);
199+
// setLastResult(UploadResult.UNKNOWN);
200200
}
201201

202202
/**

Diff for: app/src/main/java/com/owncloud/android/db/UploadResult.java

+6-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,8 @@ public enum UploadResult {
4444
OLD_ANDROID_API(18),
4545
SYNC_CONFLICT(19),
4646
CANNOT_CREATE_FILE(20),
47-
LOCAL_STORAGE_NOT_COPIED(21);
47+
LOCAL_STORAGE_NOT_COPIED(21),
48+
QUOTA_EXCEEDED(22);
4849

4950
private final int value;
5051

@@ -104,6 +105,8 @@ public static UploadResult fromValue(int value) {
104105
return CANNOT_CREATE_FILE;
105106
case 21:
106107
return LOCAL_STORAGE_NOT_COPIED;
108+
case 22:
109+
return QUOTA_EXCEEDED;
107110
}
108111
return UNKNOWN;
109112
}
@@ -162,6 +165,8 @@ public static UploadResult fromOperationResult(RemoteOperationResult result) {
162165
return VIRUS_DETECTED;
163166
case CANNOT_CREATE_FILE:
164167
return CANNOT_CREATE_FILE;
168+
case QUOTA_EXCEEDED:
169+
return QUOTA_EXCEEDED;
165170
default:
166171
return UNKNOWN;
167172
}

Diff for: app/src/main/java/com/owncloud/android/ui/adapter/UploadListAdapter.java

+3
Original file line numberDiff line numberDiff line change
@@ -703,6 +703,9 @@ private String getUploadFailedStatusText(UploadResult result) {
703703
case LOCAL_STORAGE_NOT_COPIED:
704704
status = parentActivity.getString(R.string.upload_local_storage_not_copied);
705705
break;
706+
case QUOTA_EXCEEDED:
707+
status = parentActivity.getString(R.string.quota_exceeded);
708+
break;
706709
default:
707710
status = parentActivity.getString(R.string.upload_unknown_error);
708711
break;

Diff for: app/src/main/res/values/strings.xml

+1
Original file line numberDiff line numberDiff line change
@@ -1107,4 +1107,5 @@
11071107
<string name="sub_folder_rule_year">Year</string>
11081108
<string name="sub_folder_rule_month">Year/Month</string>
11091109
<string name="sub_folder_rule_day">Year/Month/Day</string>
1110+
<string name="quota_exceeded">Quota exceeded. Free up some space on server.</string>
11101111
</resources>

Diff for: app/src/test/java/com/nextcloud/client/jobs/BackgroundJobFactoryTest.kt

-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ class BackgroundJobFactoryTest {
124124
clock,
125125
powerManagementService,
126126
{ backgroundJobManager },
127-
deviceInfo,
128127
accountManager,
129128
resources,
130129
dataProvider,

0 commit comments

Comments
 (0)