fix(revice) 리뷰반영

- 클래스 내 선언순서 조정
- 파라미터 이름 변경

Author: seungjoo.jeong

src/main/java/kitchenpos/product/application/DefaultProductUseCase.java

@@ -29,9 +29,9 @@ public DefaultProductUseCase(final ProductNameFactory nameFactory,
     }
 
     @Override
-    public void register(final Name nameCandidate, final ProductPrice price) {
+    public void register(final Name productNameCandidate, final ProductPrice price) {
         final ProductNew product
-            = ProductNew.newOf(nameFactory.create(nameCandidate), price);
+            = ProductNew.newOf(nameFactory.create(productNameCandidate), price);
 
         repository.save(product);
     }

src/main/java/kitchenpos/product/application/ProductDTO.java

@@ -2,6 +2,7 @@
 
 import static com.google.common.base.Preconditions.checkArgument;
 
+import com.google.common.base.MoreObjects;
 import java.util.UUID;
 import kitchenpos.product.domain.ProductName;
 import kitchenpos.product.domain.ProductNew;
@@ -20,4 +21,13 @@ public ProductDTO(final ProductNew entity) {
         price = entity.getPrice();
         name = entity.getName();
     }
+
+    @Override
+    public String toString() {
+        return MoreObjects.toStringHelper(this)
+            .add("id", id)
+            .add("price", price)
+            .add("name", name)
+            .toString();
+    }
 }

src/main/java/kitchenpos/product/application/port/in/ProductUseCase.java

@@ -12,12 +12,12 @@ public interface ProductUseCase {
     /**
      * @throws IllegalArgumentException nameCandidate에 비속어가 포함되어 있을 때
      */
-    void register(final Name nameCandidate, final ProductPrice price);
+    void register(final Name productNameCandidate, final ProductPrice price);
 
     /**
      * @throws NotExistProductException id에 해당하는 product가 없을 때
      */
     void changePrice(final UUID id, final ProductPrice price);
-    
+
     List<ProductDTO> findAll();
 }

src/main/java/kitchenpos/product/domain/Name.java

@@ -15,10 +15,6 @@ public Name(final String value) {
         this.value = value;
     }
 
-    public String getValue() {
-        return value;
-    }
-
     @Override
     public boolean equals(final Object o) {
         if (this == o) {
@@ -35,4 +31,8 @@ public boolean equals(final Object o) {
     public int hashCode() {
         return Objects.hashCode(value);
     }
+
+    public String getValue() {
+        return value;
+    }
 }

src/main/java/kitchenpos/product/domain/ProductName.java

@@ -10,23 +10,27 @@ public class ProductName {
 
     private String value;
 
-    public static ProductName of(final Name name) {
-        checkArgument(name != null, "name must be not null. value: %s", name);
+    protected ProductName() {
+    }
 
-        return new ProductName(name);
+    private ProductName(final Name name) {
+        this.value = name.getValue();
     }
 
-    public ProductName() {
+    static ProductName of(final Name name) {
+        checkArgument(name != null, "name must be not null. value: %s", name);
+
+        return new ProductName(name);
     }
 
     @Override
     public boolean equals(final Object o) {
-		if (this == o) {
-			return true;
-		}
-		if (o == null || getClass() != o.getClass()) {
-			return false;
-		}
+        if (this == o) {
+            return true;
+        }
+        if (o == null || getClass() != o.getClass()) {
+            return false;
+        }
         final ProductName that = (ProductName) o;
         return Objects.equal(value, that.value);
     }
@@ -35,9 +39,4 @@ public boolean equals(final Object o) {
     public int hashCode() {
         return Objects.hashCode(value);
     }
-
-
-    private ProductName(final Name name) {
-        this.value = name.getValue();
-    }
 }

src/main/java/kitchenpos/product/domain/ProductNew.java

@@ -26,27 +26,24 @@ public class ProductNew {
     @AttributeOverride(name = "value", column = @Column(name = "price"))
     private ProductPrice price;
 
-    public static ProductNew newOf(final ProductName name, final ProductPrice price) {
-        return new ProductNew(UUID.randomUUID(), name, price);
-    }
 
-    public void changePrice(final ProductPrice price) {
-        this.price = price;
+    protected ProductNew() {
     }
 
-
-    public UUID getId() {
-        return id;
+    private ProductNew(final UUID id, final ProductName name, final ProductPrice price) {
+        this.id = id;
+        this.name = name;
+        this.price = price;
     }
 
-    public ProductName getName() {
-        return name;
+    public static ProductNew newOf(final ProductName name, final ProductPrice price) {
+        return new ProductNew(UUID.randomUUID(), name, price);
     }
 
-    public ProductPrice getPrice() {
-        return price;
+    public void changePrice(final ProductPrice price) {
+        this.price = price;
     }
-
+    
     @Override
     public boolean equals(final Object o) {
         if (this == o) {
@@ -64,12 +61,15 @@ public int hashCode() {
         return Objects.hash(id);
     }
 
-    private ProductNew(final UUID id, final ProductName name, final ProductPrice price) {
-        this.id = id;
-        this.name = name;
-        this.price = price;
+    public UUID getId() {
+        return id;
+    }
+
+    public ProductName getName() {
+        return name;
     }
 
-    public ProductNew() {
+    public ProductPrice getPrice() {
+        return price;
     }
 }

src/main/java/kitchenpos/product/domain/ProductPrice.java

@@ -11,15 +11,19 @@ public class ProductPrice {
 
     private long value;
 
+    protected ProductPrice() {
+    }
+
+    private ProductPrice(final long value) {
+        this.value = value;
+    }
+
     public static ProductPrice of(final long value) {
         checkArgument(value >= 0, "price must be bigger than 0. value : %s", value);
 
         return new ProductPrice(value);
     }
 
-    public ProductPrice() {
-    }
-
     @Override
     public boolean equals(final Object o) {
         if (this == o) {
@@ -37,7 +41,4 @@ public int hashCode() {
         return Objects.hashCode(value);
     }
 
-    private ProductPrice(final long value) {
-        this.value = value;
-    }
 }