-
Notifications
You must be signed in to change notification settings - Fork 132
Add grouping categories to import hooks #1594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌MegaLinter analysis: Error
Detailed Issues❌ PYTHON / ruff - 1 errorSee detailed reports in MegaLinter artifacts |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1594 +/- ##
==========================================
+ Coverage 81.84% 81.86% +0.02%
==========================================
Files 207 207
Lines 24008 24008
Branches 3812 3812
==========================================
+ Hits 19649 19654 +5
+ Misses 3088 3084 -4
+ Partials 1271 1270 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This has always bothered me, and might be worth taking to Product. The agents don't have any standard way of disabling instrumentation but our current one is very I would be massively in favor of changing this, but would prefer something less coupled to the INI format. Ruby has one of the best formats I've seen that we're incredibly close to already which would make it easier to adopt. They don't allow disabling sub-modules as far as I can tell, and have to add a new setting for every single library they instrument. We already have |
Context for this PR: I put this out there because 1) we've had so many customers ask for something like this and 2) it would make some stuff I'm doing with Otel next quarter much easier but I wanted to give some time for everyone to think about how we'd implement something like this. I'l look into Ruby's implementation for next steps. |

This PR adds a new feature to the agent: the ability to disable instrumentation for an entire group/package/module.
Use case: If instrumentation for Django is not desired, we would have to add 22 sections into the *.ini file, disabling each individual hook
et cetera.
With this feature, we can simply use
And it will disable instrumentation for any Django hook.
Notes:
asyncioand the logging libraries do not have a separate grouping.