Skip to content

Commit 4b7d368

Browse files
Enable Github Action Linting (#1334)
* Enable ActionLint * Set additional options in megalinter --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
1 parent e46c407 commit 4b7d368

File tree

3 files changed

+49
-46
lines changed

3 files changed

+49
-46
lines changed

.github/workflows/deploy-python.yml

+6-6
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,8 @@ jobs:
120120
- name: Prepare MD5 Hash File
121121
run: |
122122
tarball="$(python setup.py --fullname).tar.gz"
123-
md5_file=${tarball}.md5
124-
openssl md5 -binary dist/${tarball} | xxd -p | tr -d '\n' > dist/${md5_file}
123+
md5_file="${tarball}.md5"
124+
openssl md5 -binary "dist/${tarball}" | xxd -p | tr -d '\n' > "dist/${md5_file}"
125125
126126
- name: Upload Artifacts
127127
uses: actions/upload-artifact@5d5d22a31266ced268874388b861e4b58bb5c2f3 # 4.3.1
@@ -169,9 +169,9 @@ jobs:
169169
- name: Upload Package to S3
170170
run: |
171171
tarball="$(python setup.py --fullname).tar.gz"
172-
md5_file=${tarball}.md5
173-
aws s3 cp dist/${md5_file} $S3_DST/${md5_file}
174-
aws s3 cp dist/${tarball} $S3_DST/${tarball}
172+
md5_file="${tarball}.md5"
173+
aws s3 cp "dist/${md5_file}" "${S3_DST}/${md5_file}"
174+
aws s3 cp "dist/${tarball}" "${S3_DST}/${tarball}"
175175
env:
176176
S3_DST: s3://nr-downloads-main/python_agent/release
177177
AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
@@ -190,7 +190,7 @@ jobs:
190190
RELEASE_TITLE="New Relic Python Agent ${GITHUB_REF_NAME}.0"
191191
RELEASE_TAG="${GITHUB_REF_NAME}.0_python"
192192
RELEASE_NOTES="Automated release for [Python Agent ${GITHUB_REF_NAME}](https://github.com/newrelic/newrelic-python-agent/releases/tag/${GITHUB_REF_NAME})"
193-
gh auth login --with-token <<< $GH_RELEASE_TOKEN
193+
gh auth login --with-token <<< "$GH_RELEASE_TOKEN"
194194
echo "newrelic/newrelic-lambda-layers - Releasing \"${RELEASE_TITLE}\" with tag ${RELEASE_TAG}"
195195
gh release create "${RELEASE_TAG}" --title="${RELEASE_TITLE}" --repo=newrelic/newrelic-lambda-layers --notes="${RELEASE_NOTES}"
196196
echo "newrelic/newrelic-agent-init-container - Releasing \"${RELEASE_TITLE}\" with tag ${RELEASE_TAG}"

.github/workflows/tests.yml

+40-40
Original file line numberDiff line numberDiff line change
@@ -181,12 +181,12 @@ jobs:
181181
- name: Configure pip cache
182182
run: |
183183
mkdir -p /github/home/.cache/pip
184-
chown -R $(whoami) /github/home/.cache/pip
184+
chown -R "$(whoami)" /github/home/.cache/pip
185185
186186
- name: Get Environments
187187
id: get-envs
188188
run: |
189-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
189+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
190190
env:
191191
GROUP_NUMBER: ${{ matrix.group-number }}
192192

@@ -230,12 +230,12 @@ jobs:
230230
- name: Configure pip cache
231231
run: |
232232
mkdir -p /github/home/.cache/pip
233-
chown -R $(whoami) /github/home/.cache/pip
233+
chown -R "$(whoami)" /github/home/.cache/pip
234234
235235
- name: Get Environments
236236
id: get-envs
237237
run: |
238-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
238+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
239239
env:
240240
GROUP_NUMBER: ${{ matrix.group-number }}
241241

@@ -293,12 +293,12 @@ jobs:
293293
- name: Configure pip cache
294294
run: |
295295
mkdir -p /github/home/.cache/pip
296-
chown -R $(whoami) /github/home/.cache/pip
296+
chown -R "$(whoami)" /github/home/.cache/pip
297297
298298
- name: Get Environments
299299
id: get-envs
300300
run: |
301-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
301+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
302302
env:
303303
GROUP_NUMBER: ${{ matrix.group-number }}
304304

@@ -357,12 +357,12 @@ jobs:
357357
- name: Configure pip cache
358358
run: |
359359
mkdir -p /github/home/.cache/pip
360-
chown -R $(whoami) /github/home/.cache/pip
360+
chown -R "$(whoami)" /github/home/.cache/pip
361361
362362
- name: Get Environments
363363
id: get-envs
364364
run: |
365-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
365+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
366366
env:
367367
GROUP_NUMBER: ${{ matrix.group-number }}
368368

@@ -421,12 +421,12 @@ jobs:
421421
- name: Configure pip cache
422422
run: |
423423
mkdir -p /github/home/.cache/pip
424-
chown -R $(whoami) /github/home/.cache/pip
424+
chown -R "$(whoami)" /github/home/.cache/pip
425425
426426
- name: Get Environments
427427
id: get-envs
428428
run: |
429-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
429+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
430430
env:
431431
GROUP_NUMBER: ${{ matrix.group-number }}
432432

@@ -488,12 +488,12 @@ jobs:
488488
- name: Configure pip cache
489489
run: |
490490
mkdir -p /github/home/.cache/pip
491-
chown -R $(whoami) /github/home/.cache/pip
491+
chown -R "$(whoami)" /github/home/.cache/pip
492492
493493
- name: Get Environments
494494
id: get-envs
495495
run: |
496-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
496+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
497497
env:
498498
GROUP_NUMBER: ${{ matrix.group-number }}
499499

@@ -555,12 +555,12 @@ jobs:
555555
- name: Configure pip cache
556556
run: |
557557
mkdir -p /github/home/.cache/pip
558-
chown -R $(whoami) /github/home/.cache/pip
558+
chown -R "$(whoami)" /github/home/.cache/pip
559559
560560
- name: Get Environments
561561
id: get-envs
562562
run: |
563-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
563+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
564564
env:
565565
GROUP_NUMBER: ${{ matrix.group-number }}
566566

@@ -658,12 +658,12 @@ jobs:
658658
- name: Configure pip cache
659659
run: |
660660
mkdir -p /github/home/.cache/pip
661-
chown -R $(whoami) /github/home/.cache/pip
661+
chown -R "$(whoami)" /github/home/.cache/pip
662662
663663
- name: Get Environments
664664
id: get-envs
665665
run: |
666-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
666+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
667667
env:
668668
GROUP_NUMBER: ${{ matrix.group-number }}
669669

@@ -720,12 +720,12 @@ jobs:
720720
- name: Configure pip cache
721721
run: |
722722
mkdir -p /github/home/.cache/pip
723-
chown -R $(whoami) /github/home/.cache/pip
723+
chown -R "$(whoami)" /github/home/.cache/pip
724724
725725
- name: Get Environments
726726
id: get-envs
727727
run: |
728-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
728+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
729729
env:
730730
GROUP_NUMBER: ${{ matrix.group-number }}
731731

@@ -784,12 +784,12 @@ jobs:
784784
- name: Configure pip cache
785785
run: |
786786
mkdir -p /github/home/.cache/pip
787-
chown -R $(whoami) /github/home/.cache/pip
787+
chown -R "$(whoami)" /github/home/.cache/pip
788788
789789
- name: Get Environments
790790
id: get-envs
791791
run: |
792-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
792+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
793793
env:
794794
GROUP_NUMBER: ${{ matrix.group-number }}
795795

@@ -846,12 +846,12 @@ jobs:
846846
- name: Configure pip cache
847847
run: |
848848
mkdir -p /github/home/.cache/pip
849-
chown -R $(whoami) /github/home/.cache/pip
849+
chown -R "$(whoami)" /github/home/.cache/pip
850850
851851
- name: Get Environments
852852
id: get-envs
853853
run: |
854-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
854+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
855855
env:
856856
GROUP_NUMBER: ${{ matrix.group-number }}
857857

@@ -909,12 +909,12 @@ jobs:
909909
- name: Configure pip cache
910910
run: |
911911
mkdir -p /github/home/.cache/pip
912-
chown -R $(whoami) /github/home/.cache/pip
912+
chown -R "$(whoami)" /github/home/.cache/pip
913913
914914
- name: Get Environments
915915
id: get-envs
916916
run: |
917-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
917+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
918918
env:
919919
GROUP_NUMBER: ${{ matrix.group-number }}
920920

@@ -983,12 +983,12 @@ jobs:
983983
- name: Configure pip cache
984984
run: |
985985
mkdir -p /github/home/.cache/pip
986-
chown -R $(whoami) /github/home/.cache/pip
986+
chown -R "$(whoami)" /github/home/.cache/pip
987987
988988
- name: Get Environments
989989
id: get-envs
990990
run: |
991-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
991+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
992992
env:
993993
GROUP_NUMBER: ${{ matrix.group-number }}
994994

@@ -1045,12 +1045,12 @@ jobs:
10451045
- name: Configure pip cache
10461046
run: |
10471047
mkdir -p /github/home/.cache/pip
1048-
chown -R $(whoami) /github/home/.cache/pip
1048+
chown -R "$(whoami)" /github/home/.cache/pip
10491049
10501050
- name: Get Environments
10511051
id: get-envs
10521052
run: |
1053-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
1053+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
10541054
env:
10551055
GROUP_NUMBER: ${{ matrix.group-number }}
10561056

@@ -1107,12 +1107,12 @@ jobs:
11071107
- name: Configure pip cache
11081108
run: |
11091109
mkdir -p /github/home/.cache/pip
1110-
chown -R $(whoami) /github/home/.cache/pip
1110+
chown -R "$(whoami)" /github/home/.cache/pip
11111111
11121112
- name: Get Environments
11131113
id: get-envs
11141114
run: |
1115-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
1115+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
11161116
env:
11171117
GROUP_NUMBER: ${{ matrix.group-number }}
11181118

@@ -1174,12 +1174,12 @@ jobs:
11741174
- name: Configure pip cache
11751175
run: |
11761176
mkdir -p /github/home/.cache/pip
1177-
chown -R $(whoami) /github/home/.cache/pip
1177+
chown -R "$(whoami)" /github/home/.cache/pip
11781178
11791179
- name: Get Environments
11801180
id: get-envs
11811181
run: |
1182-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
1182+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
11831183
env:
11841184
GROUP_NUMBER: ${{ matrix.group-number }}
11851185

@@ -1238,12 +1238,12 @@ jobs:
12381238
- name: Configure pip cache
12391239
run: |
12401240
mkdir -p /github/home/.cache/pip
1241-
chown -R $(whoami) /github/home/.cache/pip
1241+
chown -R "$(whoami)" /github/home/.cache/pip
12421242
12431243
- name: Get Environments
12441244
id: get-envs
12451245
run: |
1246-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
1246+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
12471247
env:
12481248
GROUP_NUMBER: ${{ matrix.group-number }}
12491249

@@ -1303,12 +1303,12 @@ jobs:
13031303
- name: Configure pip cache
13041304
run: |
13051305
mkdir -p /github/home/.cache/pip
1306-
chown -R $(whoami) /github/home/.cache/pip
1306+
chown -R "$(whoami)" /github/home/.cache/pip
13071307
13081308
- name: Get Environments
13091309
id: get-envs
13101310
run: |
1311-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
1311+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
13121312
env:
13131313
GROUP_NUMBER: ${{ matrix.group-number }}
13141314

@@ -1372,12 +1372,12 @@ jobs:
13721372
- name: Configure pip cache
13731373
run: |
13741374
mkdir -p /github/home/.cache/pip
1375-
chown -R $(whoami) /github/home/.cache/pip
1375+
chown -R "$(whoami)" /github/home/.cache/pip
13761376
13771377
- name: Get Environments
13781378
id: get-envs
13791379
run: |
1380-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
1380+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
13811381
env:
13821382
GROUP_NUMBER: ${{ matrix.group-number }}
13831383

@@ -1434,12 +1434,12 @@ jobs:
14341434
- name: Configure pip cache
14351435
run: |
14361436
mkdir -p /github/home/.cache/pip
1437-
chown -R $(whoami) /github/home/.cache/pip
1437+
chown -R "$(whoami)" /github/home/.cache/pip
14381438
14391439
- name: Get Environments
14401440
id: get-envs
14411441
run: |
1442-
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> $GITHUB_OUTPUT
1442+
echo "envs=$(tox -l | grep '^${{ github.job }}\-' | ./.github/workflows/get-envs.py)" >> "$GITHUB_OUTPUT"
14431443
env:
14441444
GROUP_NUMBER: ${{ matrix.group-number }}
14451445

.mega-linter.yml

+3
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,14 @@ DEFAULT_BRANCH: main # Usually master or main
66
SHOW_ELAPSED_TIME: true
77
FILEIO_REPORTER: false
88
PRINT_ALPACA: false
9+
CLEAR_REPORT_FOLDER: true
910
VALIDATE_ALL_CODEBASE: true
1011
IGNORE_GITIGNORED_FILES: true
12+
FAIL_IF_MISSING_LINTER_IN_FLAVOR: true
1113
FILTER_REGEX_EXCLUDE: "(.*/?packages/.*)" # Ignore packages directories
1214

1315
ENABLE_LINTERS: # If you use ENABLE_LINTERS variable, all other linters will be disabled by default
16+
- ACTION_ACTIONLINT
1417
- MARKDOWN_MARKDOWN_LINK_CHECK
1518
- MARKDOWN_MARKDOWNLINT
1619
- PYTHON_RUFF

0 commit comments

Comments
 (0)