Skip to content

Commit 564ecd5

Browse files
author
weilong.pwl
committed
fix resource and record bug
1 parent 500de05 commit 564ecd5

6 files changed

+7
-13
lines changed

client_alert_resource_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ func (s *UserTestSuite) TestClient_GetUser() {
118118
func (s *UserTestSuite) TestClient_ListUser() {
119119
err := s.createUser()
120120
s.Require().Nil(err)
121-
resourceRecords, total, count, err := s.client.ListResourceRecord(s.resourceName, 0, 100)
121+
resourceRecords, count, total, err := s.client.ListResourceRecord(s.resourceName, 0, 100)
122122
s.Require().Nil(err)
123123
if total < 1 || count < 1 {
124124
s.Require().Fail("list resourceRecord failed")

client_resource.go

+1-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"encoding/json"
55
"fmt"
66
"io/ioutil"
7-
"strconv"
87
)
98

109
const ResourceTypeUserDefine = "userdefine"
@@ -167,10 +166,8 @@ func (c *Client) ListResource(resourceType string, resourceName string, offset,
167166
h := map[string]string{
168167
"x-log-bodyrawsize": "0",
169168
"Content-Type": "application/json",
170-
"offset": strconv.Itoa(offset),
171-
"size": strconv.Itoa(size),
172169
}
173-
uri := fmt.Sprintf("/resources?type=%s&names=%s", resourceType, resourceName)
170+
uri := fmt.Sprintf("/resources?type=%s&names=%s&offset=%d&size=%d", resourceType, resourceName, offset, size)
174171
r, err := c.request("", "GET", uri, h, nil)
175172
if err != nil {
176173
return nil, 0, 0, err

client_resource_record.go

+1-4
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ import (
44
"encoding/json"
55
"fmt"
66
"io/ioutil"
7-
"strconv"
87
)
98

109
type ResourceRecord struct {
@@ -142,10 +141,8 @@ func (c *Client) ListResourceRecord(resourceName string, offset, size int) (reco
142141
h := map[string]string{
143142
"x-log-bodyrawsize": "0",
144143
"Content-Type": "application/json",
145-
"offset": strconv.Itoa(offset),
146-
"size": strconv.Itoa(size),
147144
}
148-
uri := fmt.Sprintf("/resources/%s/records", resourceName)
145+
uri := fmt.Sprintf("/resources/%s/records?offset=%d&size=%d", resourceName, offset, size)
149146
r, err := c.request("", "GET", uri, h, nil)
150147
if err != nil {
151148
return nil, 0, 0, err

client_resource_record_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ func (s *ResourceRecordTestSuite) TestClient_GetResourceRecord() {
128128
func (s *ResourceRecordTestSuite) TestClient_ListResourceRecord() {
129129
err := s.createResourceRecord()
130130
s.Require().Nil(err)
131-
resourceRecords, total, count, err := s.client.ListResourceRecord(s.resourceName, 0, 100)
131+
resourceRecords, count, total, err := s.client.ListResourceRecord(s.resourceName, 0, 100)
132132
s.Require().Nil(err)
133133
if total != 1 || count != 1 {
134134
s.Require().Fail("list resourceRecord failed")

client_resource_test.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,7 @@ func (s *ResourceTestSuite) TestClient_GetResource() {
124124
func (s *ResourceTestSuite) TestClient_ListResource() {
125125
err := s.createResource()
126126
s.Require().Nil(err)
127-
resources, total, count, err := s.client.ListResource(ResourceTypeUserDefine, s.resourceName, 0, 100)
127+
resources, count, total, err := s.client.ListResource(ResourceTypeUserDefine, s.resourceName, 0, 100)
128128
s.Require().Nil(err)
129129
if total != 1 || count != 1 {
130130
s.Require().Fail("list resource failed")

token_auto_update_client.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -1284,7 +1284,7 @@ func (c *TokenAutoUpdateClient) ListScheduledSQLJobInstances(projectName, jobNam
12841284
// ####################### Resource API ######################
12851285
func (c *TokenAutoUpdateClient) ListResource(resourceType string, resourceName string, offset, size int) (resourceList []*Resource, count, total int, err error) {
12861286
for i := 0; i < c.maxTryTimes; i++ {
1287-
resourceList, total, count, err = c.logClient.ListResource(resourceType, resourceName, offset, size)
1287+
resourceList, count, total, err = c.logClient.ListResource(resourceType, resourceName, offset, size)
12881288
if !c.processError(err) {
12891289
return
12901290
}
@@ -1365,7 +1365,7 @@ func (c *TokenAutoUpdateClient) CreateResourceString(resourceStr string) (err er
13651365
// ####################### Resource Record API ######################
13661366
func (c *TokenAutoUpdateClient) ListResourceRecord(resourceName string, offset, size int) (recordList []*ResourceRecord, count, total int, err error) {
13671367
for i := 0; i < c.maxTryTimes; i++ {
1368-
recordList, total, count, err = c.logClient.ListResourceRecord(resourceName, offset, size)
1368+
recordList, count, total, err = c.logClient.ListResourceRecord(resourceName, offset, size)
13691369
if !c.processError(err) {
13701370
return
13711371
}

0 commit comments

Comments
 (0)