Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear diagnosis dropdown entirely when healthy control is selected #8

Closed
1 task done
alyssadai opened this issue Dec 13, 2023 · 1 comment
Closed
1 task done
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented.

Comments

@alyssadai
Copy link
Contributor

alyssadai commented Dec 13, 2023

Is there an existing issue for this?

  • I have searched the existing issues

New feature

Currently, you can select a diagnosis value from the dropdown and then select "Healthy Control", and the result will only show you the latter even though it looks like you have selected both.

While the tooltip over healthy control is very helpful (especially in the case where you have selected "healthy control" first, the fact that you can still do the above has still confused several users.

If it is not too difficult, we should simply clear the dropdown for "diagnosis" (regardless if any have been selected already) when the "healthy control" checkbox is clicked. This will indicate the exclusively of these two options a lot more clearly.

Related comments:

Unclear documentation

No response

@alyssadai alyssadai added feedback:feature request flag:schedule Flag issue that should go on the roadmap or backlog. labels Dec 13, 2023
@alyssadai alyssadai changed the title Rework selection behaviour for healthy control and diagnosis values Clear diagnosis dropdown entirely when healthy control is selected Dec 18, 2023
@alyssadai alyssadai removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Dec 18, 2023
@surchs surchs added the flag:discuss Flag issue that needs to be discussed before it can be implemented. label Jan 8, 2024
@alyssadai alyssadai transferred this issue from neurobagel/old-query-tool Jan 12, 2024
@alyssadai alyssadai moved this from Backlog to Specify - Active in Neurobagel Jan 12, 2024
@alyssadai alyssadai removed the status in Neurobagel Jan 12, 2024
@rmanaem
Copy link
Contributor

rmanaem commented Mar 9, 2024

This has already been addressed during the refactor.

@rmanaem rmanaem closed this as completed Mar 9, 2024
@github-project-automation github-project-automation bot moved this to Review - Done in Neurobagel Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented.
Projects
Archived in project
Development

No branches or pull requests

3 participants