Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the tests to run in node mode #225

Closed
rmanaem opened this issue Jul 24, 2024 · 2 comments
Closed

Fix the tests to run in node mode #225

rmanaem opened this issue Jul 24, 2024 · 2 comments
Assignees
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented.

Comments

@rmanaem
Copy link
Contributor

rmanaem commented Jul 24, 2024

Following #223 we discovered that we've been running our tests only in federation mode and neglecting node mode. This has lead to the code becoming specific to the responses coming from federation API so many of the types, response mocks, and tests assertions are specific to query tool pointing at a federation api.

To address this we need to make adjustments to make the tests pass in the node api mode or some cases don't run certain tests that are specific federation api mode.

We also need to run tests in node API mode in our workflows.

@rmanaem rmanaem converted this from a draft issue Jul 24, 2024
@rmanaem rmanaem self-assigned this Jul 24, 2024
@surchs
Copy link
Contributor

surchs commented Jul 25, 2024

Hey @rmanaem, good catch. But I'm not convinced we want to keep maintaining both query -> f-api and query -> n-api. Especially in cases like this one where have to spend time to keep both modes in sync with each other.

Maybe this would be a good time to discuss which of the two modes we want to keep supporting.

@rmanaem rmanaem added the flag:discuss Flag issue that needs to be discussed before it can be implemented. label Jul 25, 2024
@rmanaem rmanaem moved this from Implement - Active to Specify - Active in Neurobagel Jul 25, 2024
@rmanaem
Copy link
Contributor Author

rmanaem commented Aug 2, 2024

Following a discussion, it was decided that moving forward the query tool will only talk to a federation API and required changes will be addressed in neurobagel/planning#158 and as a result we can close #223 and #224

@rmanaem rmanaem closed this as completed Aug 2, 2024
@github-project-automation github-project-automation bot moved this from Specify - Active to Review - Done in Neurobagel Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag:discuss Flag issue that needs to be discussed before it can be implemented.
Projects
Archived in project
Development

No branches or pull requests

2 participants