Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to security variables section in "Getting started" #202

Closed
2 tasks done
alyssadai opened this issue May 15, 2024 · 3 comments · Fixed by #261
Closed
2 tasks done

Link to security variables section in "Getting started" #202

alyssadai opened this issue May 15, 2024 · 3 comments · Fixed by #261
Assignees

Comments

@alyssadai
Copy link
Contributor

alyssadai commented May 15, 2024

Since our getting started instructions currently do not include changing the graph store user/admin credentials, if a deploying user wants to change the passwords after node initialization, they will have to remove the entire volume for the graph store, since the admin password cannot be changed automatically using our current script (they will need to provide the current admin password to modify it, whereas our startup script assumes that the admin password is not yet set). This is not very convenient, and means that setting up a secure deployment always incurs additional work from the user (vs. being the recommended default).

Instead, we should link to instructions to change the passwords right when first setting up a node. This is related conceptually to the optional step under "Getting started" for users who already have data, as providing the info up front will hopefully save more prepared users unnecessary extra steps during deployment.

Steps to implement

@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label May 21, 2024
@surchs surchs moved this to Backlog in Neurobagel May 21, 2024
@surchs surchs removed the flag:schedule Flag issue that should go on the roadmap or backlog. label May 21, 2024
Copy link

github-actions bot commented Aug 6, 2024

We want to keep our issues up to date and active. This issue hasn't seen any activity in the last 75 days.
We have applied the _flag:stale label to indicate that this issue should be reviewed again.
When you review, please reread the spec and then apply one of these three options:

  • prioritize: apply the flag:schedule label to suggest moving this issue into the backlog now
  • close: if the issue is no longer relevant, explain why (give others a chance to reply) and then close.
  • archive: sometimes an issue has important information or ideas but we won't work on it soon. In this case
    apply the someday label to show that this won't be prioritized. The stalebot will ignore issues with this
    label in the future. Use sparingly!

@github-actions github-actions bot added the _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again label Aug 6, 2024
@surchs
Copy link
Contributor

surchs commented Sep 19, 2024

Making this a someday issue as we have much improved the getting started docs

@surchs surchs added someday Not a priority right now, but we want to keep this around to think or discuss more. and removed _flag:stale [BOT ONLY] Flag issue that hasn't been updated in a while and needs to be triaged again labels Sep 19, 2024
@surchs surchs removed the status in Neurobagel Sep 19, 2024
@alyssadai alyssadai changed the title Add "Getting started" docs route for users with JSONLDs to use their own data for the first deployment Add "Getting started" docs route for users who already have JSONLD data Dec 2, 2024
@alyssadai alyssadai added the flag:schedule Flag issue that should go on the roadmap or backlog. label Dec 2, 2024
@alyssadai alyssadai moved this to Backlog in Neurobagel Dec 4, 2024
@alyssadai alyssadai removed the status in Neurobagel Dec 4, 2024
@surchs surchs removed flag:schedule Flag issue that should go on the roadmap or backlog. someday Not a priority right now, but we want to keep this around to think or discuss more. labels Dec 9, 2024
@surchs surchs moved this to Backlog in Neurobagel Dec 9, 2024
@surchs surchs added the flag:schedule Flag issue that should go on the roadmap or backlog. label Dec 12, 2024
@surchs surchs removed the status in Neurobagel Dec 12, 2024
@rmanaem rmanaem removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Dec 17, 2024
@rmanaem rmanaem moved this to Backlog in Neurobagel Dec 17, 2024
@surchs surchs moved this from Backlog to Specify - Active in Neurobagel Dec 19, 2024
@surchs surchs moved this from Specify - Active to Specify - Done in Neurobagel Dec 19, 2024
@alyssadai alyssadai moved this from Specify - Done to Implement - Active in Neurobagel Dec 19, 2024
@alyssadai alyssadai self-assigned this Dec 19, 2024
@alyssadai alyssadai moved this from Implement - Active to Specify - Done in Neurobagel Dec 19, 2024
@alyssadai alyssadai removed their assignment Dec 19, 2024
@alyssadai alyssadai moved this from Specify - Done to Implement - Active in Neurobagel Jan 10, 2025
@alyssadai alyssadai self-assigned this Jan 10, 2025
@alyssadai alyssadai changed the title Add "Getting started" docs route for users who already have JSONLD data Link to security variables section in "Getting started" Jan 13, 2025
@alyssadai alyssadai moved this from Implement - Active to Implement - Done in Neurobagel Jan 13, 2025
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Jan 15, 2025
@surchs
Copy link
Contributor

surchs commented Jan 15, 2025

Hey @alyssadai just a meta-comment: I'd say it's cleaner to close this issue because the original point of "add link for people who have .jsonld" has already been addressed in ff0919f - and to then open a new issue for the point about the credentials. Otherwise some of the context no longer makes sense

@github-project-automation github-project-automation bot moved this from Review - Active to Review - Done in Neurobagel Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review - Done
Development

Successfully merging a pull request may close this issue.

3 participants