Inconsistent trailing slashes in routes #399
Labels
flag:discuss
Flag issue that needs to be discussed before it can be implemented.
usability
Issue affecting user or developer experience.
In the PR for:
307
redirect which breaks reverse proxies via paths #327we globally disabled redirection of trailing slashes, such that routes by default will now only work if they are accessed exactly as defined (e.g., if the
/query
route is defined without a trailing slash, then/query/
will not work).As part of the issue spec, we decided that we would globally define routes without the trailing slash for convenience and URLs, e.g.:
However, when we then refactored the generic
/attributes
route into variable-specific routes in:/attributes
endpoints into attribute-specific routers #358we accidentally reintroduced the trailing slash into the variable routers. The result is that at the moment, we are not consistent with where we expect trailing slashes:
api.neurobagel.org/query -> works
api.neurobagel.org/query/ -> doesn't work
api.neurobagel.org/assessments -> doesn't work
api.neurobagel.org/assessments/ -> works
Steps to implement
/
for the base of each routeNOTE: The query tool and f-API may also be affected by this change
The text was updated successfully, but these errors were encountered: