Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload data dictionary component ui #39

Open
4 tasks done
rmanaem opened this issue Feb 14, 2025 · 3 comments · May be fixed by #50
Open
4 tasks done

Upload data dictionary component ui #39

rmanaem opened this issue Feb 14, 2025 · 3 comments · May be fixed by #50
Assignees

Comments

@rmanaem
Copy link
Contributor

rmanaem commented Feb 14, 2025

This component should handle the following

  • uploading of a .json file
    • [ ] prompt the user to create them an empty data dictionary if they don't have one to upload
    • Perhaps something we can add at a later time
  • showing a preview of the file
    • preview should be collapsable

Aside from component functionalities:

  • a test for the new component
@rmanaem rmanaem added the flag:schedule Flag issue that should go on the roadmap or backlog. label Feb 14, 2025
@rmanaem rmanaem transferred this issue from neurobagel/planning Feb 14, 2025
@rmanaem rmanaem self-assigned this Feb 14, 2025
@rmanaem rmanaem moved this to Backlog in Neurobagel Feb 14, 2025
@rmanaem rmanaem removed the flag:schedule Flag issue that should go on the roadmap or backlog. label Feb 14, 2025
@rmanaem rmanaem moved this from Backlog to Specify - Done in Neurobagel Feb 14, 2025
@rmanaem rmanaem changed the title Upload data dictionary component Upload data dictionary component ui Feb 14, 2025
@rmanaem rmanaem moved this from Specify - Done to Implement - Active in Neurobagel Feb 17, 2025
@rmanaem
Copy link
Contributor Author

rmanaem commented Feb 19, 2025

Blocked until #21 is addressed

@rmanaem rmanaem moved this from Implement - Active to Implement - Track in Neurobagel Feb 19, 2025
@rmanaem rmanaem moved this from Implement - Track to Implement - Active in Neurobagel Feb 19, 2025
@rmanaem
Copy link
Contributor Author

rmanaem commented Feb 19, 2025

@neurobagel/dev
Any thoughts on the preview for a data dictionary?
The expand all/collapse all only expands the first level (columns)

Image

A bit of styling:

Image

@rmanaem rmanaem added the flag:check Issue needs attention before further action label Feb 20, 2025
@alyssadai
Copy link

Interesting! @rmanaem, does that mean if the user wanted to see the data dictionary preview in full, they would have to first manually expand each level?

If so, I may prefer a version where I can simply expand or collapse the full raw JSON file. A little less fancy, but does the job I think - it would also allow the user to quickly catch formatting/obvious problems in the raw file (which I suspect the current styling may hide?).

Alternatively, if there's a way to always show the top-level keys, but be able to expand/collapse everything else at once, I think that also works. But I don't think it's super necessary.

@rmanaem rmanaem removed the flag:check Issue needs attention before further action label Feb 20, 2025
@rmanaem rmanaem linked a pull request Feb 20, 2025 that will close this issue
7 tasks
@rmanaem rmanaem moved this from Implement - Active to Automation in Neurobagel Feb 20, 2025
@rmanaem rmanaem moved this from Automation to Implement - Done in Neurobagel Feb 20, 2025
@surchs surchs moved this from Implement - Done to Review - Active in Neurobagel Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Review - Active
Development

Successfully merging a pull request may close this issue.

2 participants