Merge pull request #140 from netlify/fix/datadogSinkMetricsHostname

fix(metriks): force empty Datadog sink hostname. Service name always in prefix.

Author: smoya

metriks/config.go

@@ -4,7 +4,5 @@ type Config struct {
 	Host string `default:"localhost"`
 	Port int    `default:"8125"`
 
-	// Name is typically the local hostname or pod name
-	Name string `default:"local"`
 	Tags map[string]string
 }

metriks/metriks.go

@@ -20,7 +20,7 @@ func Init(serviceName string, conf Config) error {
 
 // InitTags behaves like Init but allows appending extra tags
 func InitTags(serviceName string, conf Config, extraTags []string) error {
-	sink, err := createDatadogSink(statsdAddr(conf), conf.Name, conf.Tags, extraTags)
+	sink, err := createDatadogSink(statsdAddr(conf), "", conf.Tags, extraTags)
 	if err != nil {
 		return err
 	}

metriks/metriks_test.go

@@ -19,7 +19,6 @@ func TestMetriksInit(t *testing.T) {
 	config := Config{
 		Host: "127.0.0.1",
 		Port: 8125,
-		Name: "dev-test",
 		Tags: nil,
 	}
 	err = Init("foo", config)