Ensure all value types can be logged with console.log w/ redaction

[DavidWells]

Getting some console.log issues when trying to log out an execa subprocess in a plugin.

async function runThing(cmd, opts) {
  const cwdPath = resolveConfigPath(opts.config)
  const subprocess = execa(`${cmd}`, {
    cwd: cwdPath,
    shell: true,
  })
  subprocess.stdout.pipe(process.stdout, { end: true })
  try {
    const { stdout } = await subprocess
    return stdout
  } catch (err) {
    console.log(subprocess)
    throw new Error(err)
  }
}

Stack trace:

 err TypeError: obj.hasOwnProperty is not a function
    at DeepMap.mapObject (/Users/davidwells/Netlify/projects/build/netlify-build/packages/@netlify-build/node_modules/deep-map/lib/deep-map.js:49:21)
    at DeepMap.map (/Users/davidwells/Netlify/projects/build/netlify-build/packages/@netlify-build/node_modules/deep-map/lib/deep-map.js:27:45)
    at DeepMap.mapObject (/Users/davidwells/Netlify/projects/build/netlify-build/packages/@netlify-build/node_modules/deep-map/lib/deep-map.js:50:36)
    at DeepMap.map (/Users/davidwells/Netlify/projects/build/netlify-build/packages/@netlify-build/node_modules/deep-map/lib/deep-map.js:27:45)
    at deepMap (/Users/davidwells/Netlify/projects/build/netlify-build/packages/@netlify-build/node_modules/deep-map/lib/deep-map.js:16:40)
    at redactValues (/Users/davidwells/Netlify/projects/build/netlify-build/packages/@netlify-build/src/utils/redact.js:13:10)
    at args.map.a (/Users/davidwells/Netlify/projects/build/netlify-build/packages/@netlify-build/src/utils/patch-logs.js:26:29)
    at Array.map (<anonymous>)
    at Object.apply (/Users/davidwells/Netlify/projects/build/netlify-build/packages/@netlify-build/src/utils/patch-logs.js:15:33)
    at runThing (/Users/davidwells/Netlify/projects/build/netlify-build/example/plugins/serverless-plugin/index.js:61:13)

It appears that deep-map logic doesn't like this object

[DavidWells]

Also undefined values throw in from patch logs.

adding if(typeof a === 'undefined') here https://github.com/netlify/build/blob/master/packages/%40netlify-build/src/utils/patch-logs.js#L15 fixes undefined.

Likewise removing https://github.com/netlify/build/blob/master/packages/%40netlify-build/src/utils/patch-logs.js#L20 makes subprocess error go away

[DavidWells]

Action item here would be:

Ensure any type of value can be console.loged from userland plugins & via core

• Strings,
• arrays,
• objects,
• functions
• undefined
• etc

Redaction might not work for all of them... not sure ¯_(ツ)_/¯

[ehmicky]

This should be fixed by #115 (not completly sure but very possible).

[ehmicky]

This should be fixed now after #115 and #140.