Skip to content

Commit 0ca17e6

Browse files
committed
lvm: add support for "all" checks
It seems rather inconvenient to have to specify all those switches by hand. Right now, I need to specify -gpst to get all the stats and, if some new metric get added (e.g. prometheus-community#159 hopefully), I need to remember to update my callers to match. This is annoying. Let's make a -a that's going to do it all for us. Hell, i'd make it the default, personally, if I wasn't worried about breaking people's stuff... This obviously conflicts with other PRs that might add another flag like this, like prometheus-community#159. Please prioritize the latter. Signed-off-by: Antoine Beaupré <[email protected]>
1 parent 4098ef9 commit 0ca17e6

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

Diff for: lvm-prom-collector

+7-1
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,14 @@ snapshots=false
4848
physical=false
4949
groups=false
5050

51-
while getopts "htpsg" opt; do
51+
while getopts "ahtpsg" opt; do
5252
case $opt in
53+
a)
54+
thin_pools=true
55+
snapshots=true
56+
physical=true
57+
groups=true
58+
;;
5359
p)
5460
physical=true
5561
;;

0 commit comments

Comments
 (0)