NGSTACK-1000 modify tests to be compatible with PHP8 and PHPUnit12

Author: Ante Prkacin

tests/DependencyInjection/NetgenOpenGraphExtensionTest.php

@@ -6,12 +6,11 @@
 
 use Matthias\SymfonyDependencyInjectionTest\PhpUnit\AbstractExtensionTestCase;
 use Netgen\Bundle\OpenGraphBundle\DependencyInjection\NetgenOpenGraphExtension;
+use PHPUnit\Framework\Attributes\DoesNotPerformAssertions;
 
 final class NetgenOpenGraphExtensionTest extends AbstractExtensionTestCase
 {
-    /**
-     * @doesNotPerformAssertions
-     */
+    #[DoesNotPerformAssertions]
     public function testItSetsValidContainerParameters(): void
     {
         $this->container->setParameter('ibexa.site_access.list', []);

tests/Handler/Literal/UrlTest.php

@@ -8,6 +8,7 @@
 use Netgen\Bundle\OpenGraphBundle\Handler\HandlerInterface;
 use Netgen\Bundle\OpenGraphBundle\Handler\Literal\Url;
 use Netgen\Bundle\OpenGraphBundle\MetaTag\Item;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\RequestStack;
@@ -37,9 +38,7 @@ public function testGettingTagsWithEmptyParams(): void
         $this->url->getMetaTags('some_tag');
     }
 
-    /**
-     * @dataProvider validResultProvider
-     */
+    #[DataProvider('validResultProvider')]
     public function testGettingTagsWithValidResult(string $input, string $output): void
     {
         $request = Request::create('https://domain.com');
@@ -54,7 +53,7 @@ public function testGettingTagsWithValidResult(string $input, string $output): v
         self::assertSame($output, $result[0]->getTagValue());
     }
 
-    public function validResultProvider(): iterable
+    public static function validResultProvider(): iterable
     {
         return [
             ['https://other.domain.com/some/path', 'https://other.domain.com/some/path'],
@@ -66,9 +65,7 @@ public function validResultProvider(): iterable
         ];
     }
 
-    /**
-     * @dataProvider validResultProviderWithoutRequest
-     */
+    #[DataProvider('validResultProviderWithoutRequest')]
     public function testGettingTagsWithValidResultAndWithoutRequest(string $input, string $output): void
     {
         $result = $this->url->getMetaTags('some_tag', [$input]);
@@ -79,7 +76,7 @@ public function testGettingTagsWithValidResultAndWithoutRequest(string $input, s
         self::assertSame($output, $result[0]->getTagValue());
     }
 
-    public function validResultProviderWithoutRequest(): iterable
+    public static function validResultProviderWithoutRequest(): iterable
     {
         return [
             ['https://other.domain.com/some/path', 'https://other.domain.com/some/path'],

tests/Handler/RegistryTest.php

@@ -20,15 +20,15 @@ protected function setUp(): void
 
     public function testAddingHandlers(): void
     {
-        $handler = $this->getMockForAbstractClass(HandlerInterface::class);
+        $handler = $this->createStub(HandlerInterface::class);
         $this->registry->addHandler('some_handler', $handler);
 
         self::assertSame($this->registry->getHandler('some_handler'), $handler);
     }
 
     public function testGettingHandlers(): void
     {
-        $handler = $this->getMockForAbstractClass(HandlerInterface::class);
+        $handler = $this->createStub(HandlerInterface::class);
         $this->registry->addHandler('some_handler', $handler);
 
         $returnedHandler = $this->registry->getHandler('some_handler');

tests/MetaTag/CollectorTest.php

@@ -48,17 +48,9 @@ protected function setUp(): void
 
     public function testCollect(): void
     {
-        $this->config->expects(self::at(0))
+        $this->config
             ->method('hasParameter')
-            ->willReturn(true);
-
-        $this->config->expects(self::at(1))
-            ->method('getParameter')
-            ->willReturn([]);
-
-        $this->config->expects(self::at(2))
-            ->method('hasParameter')
-            ->willReturn(true);
+            ->willReturnOnConsecutiveCalls(true, true);
 
         $handlers = [
             'article' => [
@@ -72,9 +64,9 @@ public function testCollect(): void
             ],
         ];
 
-        $this->config->expects(self::at(3))
+        $this->config
             ->method('getParameter')
-            ->willReturn($handlers);
+            ->willReturnOnConsecutiveCalls([], $handlers);
 
         $versionInfo = new VersionInfo(
             [
@@ -100,7 +92,7 @@ public function testCollect(): void
                 'fieldDefinitions' => [
                     new FieldDefinition(
                         [
-                            'id' => 'id',
+                            'id' => 42,
                             'identifier' => 'name',
                             'fieldTypeIdentifier' => 'eztext',
                         ],
@@ -136,18 +128,14 @@ public function testCollectWithLogicException(): void
 
         $handlers = ['all_content_types' => $handlerArray];
 
-        $this->config->expects(self::at(0))
+        $this->config
             ->method('hasParameter')
-            ->willReturn(true);
+            ->willReturnOnConsecutiveCalls(true, false);
 
-        $this->config->expects(self::at(1))
+        $this->config
             ->method('getParameter')
             ->willReturn($handlers);
 
-        $this->config->expects(self::at(2))
-            ->method('hasParameter')
-            ->willReturn(false);
-
         $versionInfo = new VersionInfo(
             [
                 'contentInfo' => new ContentInfo(
@@ -172,7 +160,7 @@ public function testCollectWithLogicException(): void
                 'fieldDefinitions' => [
                     new FieldDefinition(
                         [
-                            'id' => 'id',
+                            'id' => 42,
                             'identifier' => 'name',
                             'fieldTypeIdentifier' => 'eztext',
                         ],

tests/NetgenOpenGraphBundleTest.php

@@ -18,7 +18,7 @@ public function testItAddsCompilerPass(): void
             ->onlyMethods(['addCompilerPass'])
             ->getMock();
 
-        $container->expects(self::at(0))
+        $container->expects(self::once())
             ->method('addCompilerPass')
             ->with(new MetaTagHandlersCompilerPass());