chore: linting action improvements (#120)

* fails the lint/test action if either tests or linting fail

* wip: force a test failure

* wip: force a lint failure

* fixes tests and linting

* ignore linting for complex method

Author: jajeffries

.github/workflows/lint-tests.yml

@@ -40,12 +40,22 @@ jobs:
           pip install .[dev]
           pip install .[test]
       - name: Lint with Ruff
+        id: lint
         run: |
           ruff check --output-format=github netbox_diode_plugin/
         continue-on-error: true
       - name: Test
+        id: test
         run: |
           make docker-compose-netbox-plugin-test-cover
+        continue-on-error: true
+      - name: Check results
+        if: always()
+        run: |
+          if [[ "${{ steps.lint.outcome }}" == "failure" || "${{ steps.test.outcome }}" == "failure" ]]; then
+            echo "Either linting or tests failed"
+            exit 1
+          fi
       - name: Coverage comment
         uses: orgoro/coverage@3f13a558c5af7376496aa4848bf0224aead366ac # v3.2
         if: github.event.pull_request.head.repo.full_name == github.repository

Makefile

@@ -17,6 +17,11 @@ docker-compose-netbox-plugin-test:
 	-@$(DOCKER_COMPOSE) -f docker/docker-compose.yaml -f docker/docker-compose.test.yaml run -u root --rm netbox ./manage.py test $(TEST_FLAGS) --keepdb netbox_diode_plugin
 	@$(MAKE) docker-compose-netbox-plugin-down
 
+.PHONY: docker-compose-netbox-plugin-test-lint
+docker-compose-netbox-plugin-test-lint:
+	-@$(DOCKER_COMPOSE) -f docker/docker-compose.yaml -f docker/docker-compose.test.yaml run -u root --rm netbox ruff check --output-format=github netbox_diode_plugin
+	@$(MAKE) docker-compose-netbox-plugin-down
+
 .PHONY: docker-compose-netbox-plugin-test-cover
 docker-compose-netbox-plugin-test-cover:
 	-@$(DOCKER_COMPOSE) -f docker/docker-compose.yaml -f docker/docker-compose.test.yaml run --rm -u root -e COVERAGE_FILE=/opt/netbox/netbox/coverage/.coverage netbox sh -c "coverage run --source=netbox_diode_plugin --omit=*/migrations/* ./manage.py test --keepdb netbox_diode_plugin && coverage xml -o /opt/netbox/netbox/coverage/report.xml && coverage report -m | tee /opt/netbox/netbox/coverage/report.txt"