-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New profile: hledger/hledger-ui #6585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both profiles are nearly identical, so I don't see a need for a -common
profile.
To simplify it:
- Move hledger-common into hledger
- Make hledger-ui redirect to hledger
- Remove hledger-common
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you try to add private-etc
entries to the new profiles?
You can check what paths a program tries to access with --trace=
.
Example:
firejail --trace=trace.txt /usr/bin/foo
The output in trace.txt should contain the relevant /etc paths.
Other than program-specific files, generally a profile will have private @network,@tls-ca
if it needs internet access and private-etc @x11
if it has
a GUI.
See src/include/etc_groups.h
for the other groups.
Also, #6593 was merged and it catches (among other things) a missing newline at
EOF (which affects some of the open PRs), so please rebase all PRs to master.
https://hledger.org/
Relates to #6580.