@nestjs/core post install script fails on powershell

[IamKayrox]

Bug Report

When running npm install on an already existing project I get this error

> opencollective || exit 0

At line:1 char:16
+ opencollective || exit 0
+                ~~
The token '||' is not a valid statement separator in this version.
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : InvalidEndOfLine

When I try creating a new project with the CLI the installation fails

Current behavior

Installation and setup fails, the project won't run.
Postinstall script seems to fail when running on PowerShell

Expected behavior

Installation not failing

Environment

• Nest version: 7.1.3 | 7.2.0 | 7.6.15
• Node version: 12.16.0
• Platform Windows 10 64bits

Others:
I had set up NPM too run scripts on PowerShell

[IamKayrox]

Also, if I set npm script-shell config to cmd the post install script fails too. I managed to install this by deleting the script-shell config on npm

[micalevisk]

I think you could run npm install --ignore-scripts to bypass this

https://docs.npmjs.com/cli/v7/commands/npm-install#ignore-scripts

[IamKayrox]

I think you could run npm install --ignore-scripts to bypass this

https://docs.npmjs.com/cli/v7/commands/npm-install#ignore-scripts

I tried this, for some reason is like the installations ends up being incomplete and it won't work after that.

[hedgerh]

So it looks like the issue is that in previous nestjs versions, the postinstall script to run the opencollective log thing after install looked like

"postinstall": "opencollective || exit 0"

Which is part of the @nuxtjs/opencollective package's setup instructions https://www.npmjs.com/package/@nuxtjs/opencollective#setup

It looks like the latest version of @nestjs/core got rid of the || exit 0: https://github.com/nestjs/nest/blob/master/package.json#L26

The issue is that || isn't a valid operator in powershell. It'd look like opencollective -or exit 0 or something instead.

I'm not sure how you are gonna be able to install these v7 versions of nestjs using powershell unless you can someone stop that @nestjs/core postinstall specifically from running or throwing an error. My guess is that when you run npm install --ignore-scripts, you are stopping the postinstalls of other dependencies from running, hence the incomplete install. It doesn't appear that @nestjs/core has any preinstall, and the postinstall just outputs a message to the terminal, so ignoring that specific postinstall script shouldn't break anything.

You may want to consider using git bash or something to install on Windows instead as a last resort. Otherwise, you should try out the latest nestjs core and see if it breaks. Those sound better than forking your current nestjs/core version or something to get rid of that || exit 0.

[kamilmysliwiec]

Let's track this here nuxt-contrib/opencollective#68