Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize listings::ch06::SpamDatasetIter #176

Open
nerdai opened this issue Dec 29, 2024 · 0 comments
Open

Optimize listings::ch06::SpamDatasetIter #176

nerdai opened this issue Dec 29, 2024 · 0 comments

Comments

@nerdai
Copy link
Owner

nerdai commented Dec 29, 2024 •
edited
Loading

DataFrame.get_row() in polars is slow and discouraged but this is what is used under the hood to for getting a data observation for SpamDatasetIter.

AC:
Re-factor to not use get_row()
@nerdai nerdai converted this from a draft issue Dec 29, 2024
@nerdai nerdai moved this from Backlog to Ready in llms-from-scratch Dec 29, 2024
@nerdai nerdai changed the title Optimize SpamDatasetIter Optimize listings::ch06::SpamDatasetIter Dec 29, 2024
@nerdai nerdai moved this from Ready to Backlog in llms-from-scratch Dec 30, 2024
@nerdai nerdai moved this from Backlog to Ready in llms-from-scratch Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
llms-from-scratch
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nerdai