Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.4] EntityRenderersEvent$CreateSkullModels no longer seems to be called #1935

Closed
Fuzss opened this issue Feb 3, 2025 · 1 comment · Fixed by #1936
Closed

[1.21.4] EntityRenderersEvent$CreateSkullModels no longer seems to be called #1935

Fuzss opened this issue Feb 3, 2025 · 1 comment · Fixed by #1936
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error

Comments

@Fuzss
Copy link

Fuzss commented Feb 3, 2025

Minecraft Version: 1.21.4

NeoForge Version: 21.4.78

Description of issue:
The event is no longer run. The vanilla implementation has only very slightly changed (the map containing all skull models is no longer built beforehand, instead models are created on demand and then memoized), so the event should be simple to hook back in.
@Fuzss Fuzss added the triage Needs triaging and confirmation label Feb 3, 2025
@ChampionAsh5357 ChampionAsh5357 added bug A bug or error 1.21.4 Targeted at Minecraft 1.21.4 and removed triage Needs triaging and confirmation labels Feb 3, 2025
@ChampionAsh5357 ChampionAsh5357 mentioned this issue Feb 3, 2025
Merged
@neoforged-releases
Copy link

🚀 This issue has been resolved in NeoForge version 21.4.82-beta, as part of #1936.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.21.4 Targeted at Minecraft 1.21.4 bug A bug or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[1.21.4] Reimplement EntityRenderersEvent.CreateSkullModels ChampionAsh5357/NeoForge
2 participants
@ChampionAsh5357 @Fuzss