Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.5] Patch out call to DataFixTypes for Saved Data #1929

Open
ChampionAsh5357 opened this issue Jan 29, 2025 · 0 comments
Open

[1.21.5] Patch out call to DataFixTypes for Saved Data #1929

ChampionAsh5357 opened this issue Jan 29, 2025 · 0 comments
Labels
1.21.5 Targeted at Minecraft 1.21.5 snapshot For a snapshot version of Minecraft

Comments

@ChampionAsh5357
Copy link
Contributor

In 25w05a, SavedData moved to a type based system with data loaded from a function or a Codec. Within the SavedDataType used to construct the data instance, it has a required DataFixTypes which is hardcoded to check and update. As the enum is not made extensible and the data fixer system is avoided by NeoForge, DimensionDataStorage#readTagFromDisk should be patched to skip the update call if DataFixTypes is set to null.
@ChampionAsh5357 ChampionAsh5357 added 1.21.5 Targeted at Minecraft 1.21.5 snapshot For a snapshot version of Minecraft labels Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1.21.5 Targeted at Minecraft 1.21.5 snapshot For a snapshot version of Minecraft
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChampionAsh5357