Skip to content

Commit efbaca0

Browse files
Mats-SXFlorentinD
authored andcommitted
Fix progress logging for remote projections
Prior to this commit, an adaptive scheme was used, that increased the task volume with each processed batch. That scheme resulted in progress reaching 100% after one batch, 50% after two batches, 33% after three, and so on. Generally, the progress would be 1/b where b is the batch ordinal. For a large amount of batches, progress would reach 0%. Instead, we now use the Iterative.OPEN task mode. We do not know the total amount of incoming rows. Instead, we log progress after completing each batch.
1 parent 1fcaa09 commit efbaca0

File tree

1 file changed

+11
-0
lines changed

1 file changed

+11
-0
lines changed

core-test-utils/src/main/java/org/neo4j/gds/assertj/Extractors.java

+11
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,17 @@ public final class Extractors {
3131

3232
private Extractors() {}
3333

34+
public static ThrowingExtractor<String, String, RuntimeException> removingServerAddress() {
35+
return Extractors::removingServerAddress;
36+
}
37+
38+
private static String removingServerAddress(String message) {
39+
if (message.contains("localhost:")) {
40+
return removingServerAddress(message.replaceFirst("localhost:\\d+", "<address>"));
41+
}
42+
return message;
43+
}
44+
3445
public static ThrowingExtractor<String, String, RuntimeException> removingThreadId() {
3546
return Extractors::removeThreadId;
3647
}

0 commit comments

Comments
 (0)