Skip to content
This repository was archived by the owner on Sep 29, 2020. It is now read-only.

Commit 4a4b2c7

Browse files
committed
FIX fikset test:coverage
1 parent 64dde83 commit 4a4b2c7

File tree

8 files changed

+19
-22
lines changed

8 files changed

+19
-22
lines changed

.eslintignore

+1-2
Original file line numberDiff line numberDiff line change
@@ -1,2 +1 @@
1-
webpack.dev.js
2-
webpack.prod.js
1+
webpack/*

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@
111111
"scripts": {
112112
"test": "mocha-webpack --webpack-config webpack/webpack.test.js \"packages/**/*.spec.jsx\"",
113113
"test:watch": "mocha-webpack --watch --webpack-config webpack/webpack.test.watch.js \"packages/**/*.spec.jsx\"",
114-
"test:coverage": "nyc mocha-webpack --webpack-config webpack/webpack.test.coverage.js \"packages/*/**/*.jsx\"",
114+
"test:coverage": "nyc mocha-webpack --webpack-config webpack/webpack.test.coverage.js \"packages/fpsak/*/**/*.jsx\"",
115115
"dev": "cross-env NODE_ENV=development node webpack/webpack.dev.server.js --config webpack/webpack.dev.js",
116116
"build": "cross-env NODE_ENV=production webpack --progress --colors --config webpack/webpack.prod.js",
117117
"postinstall": "yarn run build && yarn test && yarn run less:lint",

packages/assets/testHelpers/setup.jsx

+3
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,6 @@ global.HTMLElement = dom.window.HTMLElement;
3434
global.requestAnimationFrame = (cb) => {
3535
setTimeout(cb, 0);
3636
};
37+
global.cancelAnimationFrame = (cb) => {
38+
setTimeout(cb, 0);
39+
};

packages/shared-components/ErrorMessagePanel.jsx

+8-4
Original file line numberDiff line numberDiff line change
@@ -125,19 +125,23 @@ export const getErrorMessageList = ownProps => createSelector(
125125
(errorMessages, errorMessageCodeWithParams, crashMessage, showDetailedErrorMessages, asyncErrorMessages) => {
126126
if (ownProps.queryStrings.errorcode) {
127127
return [{ message: ownProps.intl.formatMessage({ id: ownProps.queryStrings.errorcode }) }];
128-
} if (ownProps.queryStrings.errormessage) {
128+
}
129+
if (ownProps.queryStrings.errormessage) {
129130
return [{ message: ownProps.queryStrings.errormessage }];
130-
} if (crashMessage) {
131+
}
132+
if (crashMessage) {
131133
return [{ message: crashMessage }];
132-
} if (errorMessageCodeWithParams) {
134+
}
135+
if (errorMessageCodeWithParams) {
133136
return [{
134137
message: ownProps.intl.formatMessage({ id: errorMessageCodeWithParams.code },
135138
filterMessage(errorMessageCodeWithParams.params, showDetailedErrorMessages)),
136139
additionalInfo: errorMessageCodeWithParams.params.errorDetails
137140
? JSON.parse(decodeHtmlEntity(errorMessageCodeWithParams.params.errorDetails))
138141
: undefined,
139142
}];
140-
} if (errorMessages) {
143+
}
144+
if (errorMessages) {
141145
return errorMessages.map(em => ({ message: em }));
142146
}
143147
return asyncErrorMessages.map(em => ({ message: em }));

packages/shared-components/Header.jsx

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ import logoUrl from '@fpsak-frontend/assets/images/nav.svg';
88
import navAnsattIkonUrl from '@fpsak-frontend/assets/images/nav_ansatt.svg';
99
import rettskildeneIkonUrl from '@fpsak-frontend/assets/images/rettskildene.svg';
1010
import systemrutineIkonUrl from '@fpsak-frontend/assets/images/rutine.svg';
11-
1211
import Image from './Image';
1312
import ErrorMessagePanel from './ErrorMessagePanel';
1413

webpack/webpack.test.coverage.js

+3-6
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,9 @@
1-
2-
31
const HappyPack = require('happypack');
42
const path = require('path');
53
const merge = require('webpack-merge');
64
const common = require('./webpack.common.js');
75

8-
const APP_DIR = path.resolve(__dirname, '../packages/fpsak');
9-
6+
const PACAKGES_DIR = path.join(__dirname, '../packages');
107
const config = {
118
mode: 'development',
129
devtool: 'eval',
@@ -15,8 +12,8 @@ const config = {
1512
rules: [{
1613
test: /\.jsx?$/,
1714
use: ['istanbul-instrumenter-loader', 'happypack/loader'],
18-
include: APP_DIR,
19-
exclude: /node_modules/,
15+
include: PACAKGES_DIR,
16+
exclude: /(node_modules|testHelpers)/,
2017
}, {
2118
test: /\.(less|css|jpg|png|svg)$/,
2219
loader: 'null-loader',

webpack/webpack.test.js

+2-4
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
2-
31
const path = require('path');
42
const merge = require('webpack-merge');
53
const commonTest = require('./webpack.common.test.js');
@@ -20,12 +18,12 @@ const config = {
2018
cache: true,
2119
},
2220
include: [PACAKGES_DIR],
23-
exclude: ['/node_modules/'],
21+
exclude: ['/node_modules/, /assets/'],
2422
}, {
2523
test: /\.jsx?$/,
2624
use: ['happypack/loader'],
2725
include: [PACAKGES_DIR],
28-
exclude: ['/node_modules/'],
26+
exclude: ['/node_modules/, /assets/'],
2927
}],
3028
},
3129
};

webpack/webpack.test.watch.js

+1-4
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,6 @@
1-
2-
31
const path = require('path');
42
const merge = require('webpack-merge');
53
const commonTest = require('./webpack.common.test.js');
6-
74
const PACAKGES_DIR = path.join(__dirname, '../packages');
85
const config = {
96
mode: 'development',
@@ -20,7 +17,7 @@ const config = {
2017
cache: true,
2118
},
2219
include: [PACAKGES_DIR],
23-
exclude: ['/node_modules/'],
20+
exclude: ['/node_modules/, /assets/'],
2421
}, {
2522
test: /\.jsx?$/,
2623
use: ['happypack/loader'],

0 commit comments

Comments
 (0)