Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examine TLV bounding #375

Closed
dccutrig opened this issue Dec 17, 2024 · 2 comments
Closed

Examine TLV bounding #375

dccutrig opened this issue Dec 17, 2024 · 2 comments
Assignees
@dccutrig

Comments

@dccutrig
Copy link
Contributor

Examine TLV bounding in Crypto_Process_Extended_Procedure_Pdu.

Need to ensure that TLV values in a packet are:

  1. Less than or equal to Max TLV Length (done, and fixed otherwise segfault - UTs exist) , and
  2. That TLV values make sense in the context of the length of both frames and space packets received

2 is a little more complicated and I can revisit
@dccutrig dccutrig self-assigned this Dec 17, 2024
dccutrig added a commit that referenced this issue Dec 18, 2024
@dccutrig
[#375] WIP - shows a good example of TLV actually being corrupted and…
a0d1e6b 
… deactivating a bunch of keys. Tests are being worked pre-development
@dccutrig
Copy link
Contributor Author

Behold, an example of what mismatched lengths and corrupted values can currently do - and also the point of this issue:

image

dccutrig added a commit that referenced this issue Dec 19, 2024
@dccutrig
[#375] WIP on UTs for TLV testing, rename tlv 'pdu' name to actually …
8773bcb 
…be tlv_pdu for clarity
dccutrig added a commit that referenced this issue Dec 19, 2024
@dccutrig
[#375] Wording in crypto_print for TLVs
7f941bf
Donnie-Ice added a commit that referenced this issue Feb 10, 2025
@Donnie-Ice
[#375] Added edge checks to Crypto_Key_Update
70ea14c
Donnie-Ice added a commit that referenced this issue Feb 10, 2025
@Donnie-Ice
[#375] Wrap print in debug
829d439
Donnie-Ice added a commit that referenced this issue Feb 10, 2025
@Donnie-Ice
[#375] Expand EP functionality
51e2f45
Donnie-Ice added a commit that referenced this issue Feb 10, 2025
@Donnie-Ice
[#375] Correct error codes in UTs
1f5ba96
@Donnie-Ice
Copy link
Contributor

Need to look deeper into sa_start

Donnie-Ice added a commit that referenced this issue Feb 11, 2025
@Donnie-Ice
[#375] Exercise sa_start function
2caaef7
Donnie-Ice added a commit that referenced this issue Feb 11, 2025
@Donnie-Ice
[#375] UT to test max size on sa_start (WIP)
a161ade
Donnie-Ice added a commit that referenced this issue Feb 12, 2025
@Donnie-Ice
[#375] Expand sa_start debugging
ed13cf8
Donnie-Ice added a commit that referenced this issue Feb 18, 2025
@Donnie-Ice
[#375] Add length checks to OTAR
669a583
Donnie-Ice added a commit that referenced this issue Feb 21, 2025
@Donnie-Ice
[#375] Added Crypto_Interface init debug prints
49755ce
Donnie-Ice added a commit that referenced this issue Feb 21, 2025
@Donnie-Ice
[#375] Added crypto.c max tlv checks, debug prints, and errors
172863f
Donnie-Ice added a commit that referenced this issue Feb 21, 2025
@Donnie-Ice
[#375] Fix wrong length variable used
d700a2b
Donnie-Ice added a commit that referenced this issue Mar 3, 2025
@Donnie-Ice
[#375] Further expansion of UTs
cf28a02
Donnie-Ice added a commit that referenced this issue Mar 7, 2025
@Donnie-Ice
[#375] Fix key verification reply struct
1c27b67
Donnie-Ice added a commit that referenced this issue Mar 7, 2025
@Donnie-Ice
[#375] Fix a few clang warnings
d993c17
Donnie-Ice added a commit that referenced this issue Mar 7, 2025
@Donnie-Ice
[#375] Expand key_verify tests
042e9f6
Donnie-Ice added a commit that referenced this issue Mar 7, 2025
@Donnie-Ice
[#375] Add OCF length calculations
231e16c
Donnie-Ice added a commit that referenced this issue Mar 7, 2025
@Donnie-Ice
[#375] Fix key_deactivate UT
2921adc
@Donnie-Ice Donnie-Ice moved this to In Progress in CryptoLib Path Forward Mar 13, 2025
dccutrig added a commit that referenced this issue Mar 18, 2025
@dccutrig
[#375] TLV length test updates
325611a
dccutrig added a commit that referenced this issue Mar 18, 2025
@dccutrig
[#375] Minor UT Update, rename CCSDS_PUS to ECSS_PUS, Rename CCSDS_HD…
f4388c9 
…R to CCSDS_SPP_HDR
dccutrig added a commit that referenced this issue Mar 20, 2025
@dccutrig
[#375] Merge branch 'dev' into 375-ep-tlv-checks
3b5aa8f
dccutrig added a commit that referenced this issue Mar 20, 2025
@dccutrig
[#375] Remove code cov files
b6cdce8
dccutrig added a commit that referenced this issue Mar 20, 2025
@dccutrig
[#375] ut_ep_key_mgmt tests passing
be188dd
@Donnie-Ice Donnie-Ice mentioned this issue Mar 20, 2025
Open
dccutrig added a commit that referenced this issue Mar 24, 2025
@dccutrig
[#375] Update FHECF UT, all tests passing. AOS_UT will need reworked …
031edd6 
…as RS work matures.
dccutrig added a commit that referenced this issue Mar 24, 2025
@dccutrig
[#375] Remove accidentally committed files
ffe2396
dccutrig added a commit that referenced this issue Mar 24, 2025
@dccutrig
[#375] Update ignores
a0433de
dccutrig added a commit that referenced this issue Mar 24, 2025
@dccutrig
[#375] Ran formatter
96e26c9
dccutrig added a commit that referenced this issue Mar 24, 2025
@dccutrig
[#375] Fix unused variable warning depending on build
ed43ae6
dccutrig added a commit that referenced this issue Mar 24, 2025
@dccutrig
[#375] Fix fail on unused var depending on build
c47f04a
Donnie-Ice added a commit that referenced this issue Mar 24, 2025
@Donnie-Ice
[#375] fix aos_apply UT
4c6f275
Donnie-Ice added a commit that referenced this issue Mar 24, 2025
@Donnie-Ice
[#375] remove support/scripts/makefile
8441868
Donnie-Ice added a commit that referenced this issue Mar 24, 2025
@Donnie-Ice
[#375] attempt to use workflow builds to debug
b3a4796
Donnie-Ice added a commit that referenced this issue Mar 24, 2025
@Donnie-Ice
[#375] attempt 2 to use workflow builds to debug
5a41aa7
Donnie-Ice added a commit that referenced this issue Mar 24, 2025
@Donnie-Ice
[#375] attempt 3 to use workflow builds to debug
5209577
Donnie-Ice added a commit that referenced this issue Mar 24, 2025
@Donnie-Ice
[#375] attempt 4 to use workflow builds to debug
37fd0c8
Donnie-Ice added a commit that referenced this issue Mar 24, 2025
@Donnie-Ice
[#375] revert fhecf to last working value in CI
5b15560
Donnie-Ice added a commit that referenced this issue Mar 24, 2025
@Donnie-Ice
[#375] revert fecf to last working value in CI
c07f936
dccutrig added a commit that referenced this issue Mar 24, 2025
@dccutrig
[#375] Remove extraneous debug prints
720d885
dccutrig added a commit that referenced this issue Mar 24, 2025
@dccutrig
[#375] Remove extraneous debug prints
66ce9c6
dccutrig added a commit that referenced this issue Mar 24, 2025
@dccutrig
[#375] Update lengths to not allow for variable bit fields less than …
8cc95a0 
…a byte in size
@github-project-automation github-project-automation bot moved this from In Progress to Done in CryptoLib Path Forward Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dccutrig dccutrig

Labels
None yet
Projects
CryptoLib Path Forward
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Donnie-Ice @dccutrig