[#422] Fix magic number

Author: Donnie-Ice

include/crypto_config.h

@@ -137,6 +137,7 @@
 #define BYTE_LEN            8    /* bits */
 #define CRYPTOLIB_APPID     128
 #define MAX_IV_LEN          32   /* bytes */
+#define CBC_MAX_PAD         16   /* bytes */
 
 // Monitoring and Control Defines
 #define EMV_SIZE 4  /* bytes */
@@ -198,6 +199,7 @@
 #define TC_SN_WINDOW       10               /* +/- value */
 #define TC_FRAME_DATA_SIZE 1019 /* bytes */ // 1024 - 5byte header
 #define TC_CADU_ASM_SIZE   4
+#define TC_BLOCK_SIZE 16
 
 // CCSDS PUS Defines
 #define TLV_DATA_SIZE 494 /* bytes */
@@ -249,9 +251,4 @@
 */
 #define CRYPTO_SA_SAVE "sa_save_file.bin"
 
-/*
-** TC_BLOCK_SIZE
-*/
-#define TC_BLOCK_SIZE 16
-
 #endif // CRYPTO_CONFIG_H

src/core/crypto_aos.c

@@ -130,7 +130,7 @@ int32_t Crypto_AOS_ApplySecurity(uint8_t *pTfBuffer, uint16_t len_ingest)
     }
     else if ((sa_ptr->ecs == CRYPTO_CIPHER_AES256_CBC) || (sa_ptr->ecs == CRYPTO_CIPHER_AES256_CBC_MAC))
     {
-        if((current_managed_parameters_struct.max_frame_size - len_ingest) <= 16)
+        if((current_managed_parameters_struct.max_frame_size - len_ingest) <= CBC_MAX_PAD)
         {
             cbc_padding = current_managed_parameters_struct.max_frame_size - len_ingest;
         }

src/core/crypto_tm.c

@@ -768,7 +768,7 @@ int32_t Crypto_TM_ApplySecurity(uint8_t *pTfBuffer, uint16_t len_ingest)
     }
     else if ((sa_ptr->ecs == CRYPTO_CIPHER_AES256_CBC) || (sa_ptr->ecs == CRYPTO_CIPHER_AES256_CBC_MAC))
     {
-        if((current_managed_parameters_struct.max_frame_size - len_ingest) <= 16)
+        if((current_managed_parameters_struct.max_frame_size - len_ingest) <= CBC_MAX_PAD)
         {
             cbc_padding = current_managed_parameters_struct.max_frame_size - len_ingest;
         }