bug fix

Author: modyf01

midi_app_controller/models/app_state.py

@@ -29,4 +29,4 @@ class AppState(YamlBaseModel):
     selected_midi_out: Optional[str]
 
     recent_binds_for_controller: dict[Path, Optional[Path]]
-    recent_midi_ports_for_controller: dict[Path, dict[str, str]]
+    recent_midi_ports_for_controller: dict[Path, dict[str, Optional[str]]]

midi_app_controller/state/state_manager.py

@@ -203,28 +203,17 @@ def select_controller_path(self, controller_path: Optional[Path]) -> None:
             else None
         )
 
-    def create_selected_ports_dict(self) -> dict[str, str]:
-        selected_ports_dict = {}
-        if self.selected_midi_in is not None:
-            selected_ports_dict["in"] = self.selected_midi_in
-
-        if self.selected_midi_out is not None:
-            selected_ports_dict["out"] = self.selected_midi_out
-        return selected_ports_dict
-
     def select_midi_in(self, port_name: Optional[str]) -> None:
         """Updates currently selected MIDI input port name.
 
         Does not have any immediate effect except updating the value.
         """
         self.selected_midi_in = port_name
         if self.selected_controller:
-            selected_ports_dict = self.create_selected_ports_dict()
-
-            if selected_ports_dict:
-                self.recent_midi_ports_for_controller[self.selected_controller.path] = (
-                    selected_ports_dict
-                )
+            self.recent_midi_ports_for_controller[self.selected_controller.path] = {
+                "in": self.selected_midi_in,
+                "out": self.selected_midi_out,
+            }
 
     def select_midi_out(self, port_name: Optional[str]) -> None:
         """Updates currently selected MIDI output port name.
@@ -233,12 +222,10 @@ def select_midi_out(self, port_name: Optional[str]) -> None:
         """
         self.selected_midi_out = port_name
         if self.selected_controller:
-            selected_ports_dict = self.create_selected_ports_dict()
-
-            if selected_ports_dict:
-                self.recent_midi_ports_for_controller[self.selected_controller.path] = (
-                    selected_ports_dict
-                )
+            self.recent_midi_ports_for_controller[self.selected_controller.path] = {
+                "in": self.selected_midi_in,
+                "out": self.selected_midi_out,
+            }
 
     def stop_handling(self) -> None:
         """Stops handling any MIDI signals."""