Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

希望可以将服务端的健康检查接口暴露到namingclient中 #676

Closed
lixiangwuxian opened this issue Nov 6, 2023 · 2 comments
Closed
Labels
good first issue Good for newcomers

Comments

@lixiangwuxian
Copy link
Contributor

Use case(s) - what problem will this feature solve?

客户端启动时,可以通过调用ServerHealthy()无副作用地获取对应nacos server的连通状况,决定继续服务还是暂停获取信息。

Proposed Solution

目前浏览sdk代码时发现 naming_client.NamingClient 类中的私有成员 serviceProxy 的接口拥有ServerHealthy()方法,但无法从项目中直接调用。

希望可以将 ServerHealthy() 方法暴露到 naming_client.INamingClient 接口中,可以通过创建的naming client直接调用。

Alternatives Considered

Additional Context

@binbin0325 binbin0325 added the good first issue Good for newcomers label Nov 6, 2023
@binbin0325
Copy link
Member

可以的,如果感兴趣欢迎提交pr

@lixiangwuxian
Copy link
Contributor Author

#677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants