Merge pull request relay-tools#160 from renanmav/fix/duplicate-imports

Fix duplicate imports

Author: renanmav

package.json

@@ -89,7 +89,7 @@
     "jest": "^24.8.0",
     "jest-cli": "^24.8.0",
     "lint-staged": "^9.2.1",
-    "prettier": "^1.18.2",
+    "prettier": "^1.19.1",
     "relay-compiler": "^7.0.0",
     "relay-runtime": "^7.0.0",
     "relay-test-utils-internal": "^7.0.0",

src/TypeScriptGenerator.ts

@@ -48,9 +48,8 @@ const MODULE_IMPORT_FIELD = "MODULE_IMPORT_FIELD";
 const DIRECTIVE_NAME = "raw_response_type";
 
 export const generate: TypeGenerator["generate"] = (schema, node, options) => {
-  const ast: ts.Statement[] = IRVisitor.visit(
-    node,
-    createVisitor(schema, options)
+  const ast: ts.Statement[] = aggregateRuntimeImports(
+    IRVisitor.visit(node, createVisitor(schema, options))
   );
 
   const printer = ts.createPrinter({ newLine: ts.NewLineKind.LineFeed });
@@ -68,6 +67,57 @@ export const generate: TypeGenerator["generate"] = (schema, node, options) => {
   return printer.printNode(ts.EmitHint.SourceFile, fullProgramAst, resultFile);
 };
 
+function aggregateRuntimeImports(ast: ts.Statement[]) {
+  const importNodes = ast.filter(declaration =>
+    ts.isImportDeclaration(declaration)
+  ) as ts.ImportDeclaration[];
+
+  const runtimeImports = importNodes.filter(
+    importDeclaration =>
+      // @ts-ignore
+      importDeclaration.moduleSpecifier.text === "relay-runtime"
+  );
+
+  if (runtimeImports.length > 1) {
+    const namedImports: string[] = [];
+    runtimeImports.map(node => {
+      // @ts-ignore
+      node.importClause.namedBindings.elements.map(element => {
+        namedImports.push(element.name.escapedText);
+      });
+    });
+
+    const importSpecifiers: ts.ImportSpecifier[] = [];
+    namedImports.map(namedImport => {
+      const specifier = ts.createImportSpecifier(
+        undefined,
+        ts.createIdentifier(namedImport)
+      );
+      importSpecifiers.push(specifier);
+    });
+
+    const namedBindings = ts.createNamedImports(importSpecifiers);
+    const aggregatedRuntimeImportDeclaration = ts.createImportDeclaration(
+      undefined,
+      undefined,
+      ts.createImportClause(undefined, namedBindings),
+      ts.createStringLiteral("relay-runtime")
+    );
+
+    const aggregatedRuntimeImportAST = ast.reduce<ts.Statement[]>(
+      (prev, curr) => {
+        if (!ts.isImportDeclaration(curr)) prev.push(curr);
+        return prev;
+      },
+      [aggregatedRuntimeImportDeclaration]
+    );
+
+    return aggregatedRuntimeImportAST;
+  } else {
+    return ast;
+  }
+}
+
 function nullthrows<T>(obj: T | null | undefined): T {
   if (obj == null) {
     throw new Error("Obj is null");

test/__snapshots__/TypeScriptGenerator-test.ts.snap

@@ -1535,8 +1535,7 @@ export type RefetchableFragment$key = {
 
 
 // RefetchableFragmentQuery.graphql
-import { FragmentReference } from "relay-runtime";
-import { FragmentRefs } from "relay-runtime";
+import { FragmentReference, FragmentRefs } from "relay-runtime";
 export type RefetchableFragmentQueryVariables = {
     id: string;
 };

yarn.lock

@@ -4854,10 +4854,10 @@ preserve@^0.2.0:
   resolved "https://registry.yarnpkg.com/preserve/-/preserve-0.2.0.tgz#815ed1f6ebc65926f865b310c0713bcb3315ce4b"
   integrity sha1-gV7R9uvGWSb4ZbMQwHE7yzMVzks=
 
-prettier@^1.18.2:
-  version "1.18.2"
-  resolved "https://registry.yarnpkg.com/prettier/-/prettier-1.18.2.tgz#6823e7c5900017b4bd3acf46fe9ac4b4d7bda9ea"
-  integrity sha512-OeHeMc0JhFE9idD4ZdtNibzY0+TPHSpSSb9h8FqtP+YnoZZ1sl8Vc9b1sasjfymH3SonAF4QcA2+mzHPhMvIiw==
+prettier@^1.19.1:
+  version "1.19.1"
+  resolved "https://registry.yarnpkg.com/prettier/-/prettier-1.19.1.tgz#f7d7f5ff8a9cd872a7be4ca142095956a60797cb"
+  integrity sha512-s7PoyDv/II1ObgQunCbB9PdLmUcBZcnWOcxDh7O0N/UwDEsHyqkW+Qh28jW+mVuCdx7gLB0BotYI1Y6uI9iyew==
 
 pretty-format@^22.4.0, pretty-format@^22.4.3:
   version "22.4.3"