Skip to content

Commit 67940fc

Browse files
committed
No need to create an intermediate list
1 parent fb9de67 commit 67940fc

File tree

1 file changed

+4
-13
lines changed

1 file changed

+4
-13
lines changed

src/main/java/org/mybatis/dynamic/sql/update/render/UpdateRenderer.java

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
*/
1616
package org.mybatis.dynamic.sql.update.render;
1717

18-
import java.util.List;
1918
import java.util.Objects;
2019
import java.util.Optional;
2120
import java.util.stream.Collectors;
@@ -77,23 +76,15 @@ private FragmentAndParameters calculateUpdateStatementStart() {
7776
}
7877

7978
private FragmentAndParameters calculateSetPhrase() {
80-
List<Optional<FragmentAndParameters>> fragmentsAndParameters = updateModel.columnMappings()
79+
FragmentCollector fragmentsCollector = updateModel.columnMappings()
8180
.map(m -> m.accept(visitor))
82-
.toList();
83-
84-
Validator.assertFalse(fragmentsAndParameters.stream().noneMatch(Optional::isPresent),
85-
"ERROR.18"); //$NON-NLS-1$
86-
87-
FragmentCollector fragmentCollector = fragmentsAndParameters.stream()
8881
.flatMap(Optional::stream)
8982
.collect(FragmentCollector.collect());
9083

91-
return toSetPhrase(fragmentCollector);
92-
}
84+
Validator.assertFalse(fragmentsCollector.isEmpty(), "ERROR.18"); //$NON-NLS-1$
9385

94-
private FragmentAndParameters toSetPhrase(FragmentCollector fragmentCollector) {
95-
return fragmentCollector.toFragmentAndParameters(
96-
Collectors.joining(", ", "set ", "")); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
86+
return fragmentsCollector.toFragmentAndParameters(
87+
Collectors.joining(", ", "set ", "")); //$NON-NLS-1$ //$NON-NLS-2$ //$NON-NLS-3$
9788
}
9889

9990
private Optional<FragmentAndParameters> calculateWhereClause() {

0 commit comments

Comments
 (0)