Skip to content

Commit

Permalink
Render Tests Maintenance (maplibre#2199)
Browse files Browse the repository at this point in the history
  • Loading branch information
louwers authored Mar 15, 2024
1 parent 41b7366 commit 63ea5dc
Show file tree
Hide file tree
Showing 16 changed files with 6 additions and 309 deletions.
2 changes: 2 additions & 0 deletions platform/android/DEVELOPING.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ Run the configuration for the `MapboxGLAndroidSDKTestApp` module and select a de

To run the render tests for Android, run the configuration for the `androidRenderTest.app` module.

More information on working on the render tests can be found [in the wiki](https://github.com/maplibre/maplibre-native/wiki/Working-on-Android-Render-Tests).

## Instrumentation Tests

To run the instrumentatin tests, find the `MapboxGLAndroidSDKTestApp` project in the sidebar, go to `src > androidTest`, right click and select "Run 'All Tests'".
Expand Down
6 changes: 3 additions & 3 deletions platform/android/DISTRIBUTE.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Distributing Mapbox GL Native for Android
# Distributing MapLibre Native for Android

Depending on your use case, you may want to support all or just a subset of [Android ABIs](http://developer.android.com/ndk/guides/abis.html). This document covers building an `.aar` file from the Mapbox Maps SDK for Android and building `.so` files for specific ABIs. In normal circumstances an application developer will use [APK splits](https://developer.android.com/studio/build/configure-apk-splits.html) to optimize this at application level.
Depending on your use case, you may want to support all or just a subset of [Android ABIs](http://developer.android.com/ndk/guides/abis.html). This document covers building an `.aar` file from the MapLibre Native for Android and building `.so` files for specific ABIs. In normal circumstances an application developer will use [APK splits](https://developer.android.com/studio/build/configure-apk-splits.html) to optimize this at application level.

##### Build types

Expand All @@ -24,7 +24,7 @@ This will build native libraries to support following ABIs:
- x86_64
- mips

After succesfully finish building the native libraries, gradle will build the MapboxAndroidSDK module and generate an Android Archive file in `MapboxAndroidSDK/build/outputs/aar `. The packaged native libraries can be found in `MapboxAndroidSDK/src/main/jniLibs/<abi>`.
After successfully finish building the native libraries, Gradle will build the MapboxAndroidSDK module and generate an Android Archive file in `MapboxAndroidSDK/build/outputs/aar `. The packaged native libraries can be found in `MapboxAndroidSDK/src/main/jniLibs/<abi>`.

##### Build native libraries for a specific ABI

Expand Down
2 changes: 1 addition & 1 deletion render-test/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ android {
compileSdkVersion 33

defaultConfig {
applicationId = 'com.mapbox.mapboxsdk.maps.render_test_runner'
applicationId = 'org.maplibre.render_test_runner'
minSdkVersion 21
targetSdkVersion 33
def abi = 'all'
Expand Down
4 changes: 0 additions & 4 deletions render-test/ios/README.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
# iOS RenderTestRunner App

This is a blank single-view-controller iOS app, linked against to a C++ static libraries, plus a a simple unit xctest. We use CMake to create an Xcode-friendly out-of-source build system. In another word, the build system is maintained by `CMakeLists` file,instead of a configured `.xcodeproj` file.

This CMake project can build the executable RenderTestApp which is linked to the static C++ library 'mbgl-render-test'. CMakeLists.txt files are the only build configuration kept in source control. This is in contrast to committing the `.xcodeproj` directory which includes the backing XML, which is nonsensically hard to edit by hand.

The test instantiates ObjC object of class `IosTestRunner` from the app, the class will instantiates a C++ object from the linked library `mbgl-render-test` and calls running render test function on it. It subsequently deletes the C++ object pointer. In the end, the test will check the existence of test reports, which are html files that attach to xctest result.
68 changes: 0 additions & 68 deletions render-test/ios/RenderTestApp_iphoneos13.2-arm64e-debug.xctestrun

This file was deleted.

This file was deleted.

16 changes: 0 additions & 16 deletions render-test/ios/codesigning/RenderTestApp.app.xcent.template

This file was deleted.

This file was deleted.

This file was deleted.

16 changes: 0 additions & 16 deletions render-test/ios/codesigning/XCTest.framework.xcent.template

This file was deleted.

11 changes: 0 additions & 11 deletions render-test/ios/codesigning/codesign_all.sh

This file was deleted.

40 changes: 0 additions & 40 deletions render-test/ios/codesigning/generate-entitlements.swift

This file was deleted.

This file was deleted.

3 changes: 0 additions & 3 deletions render-test/ios/fastlane/Appfile

This file was deleted.

5 changes: 0 additions & 5 deletions render-test/ios/fastlane/Matchfile

This file was deleted.

26 changes: 0 additions & 26 deletions render-test/ios/setup_test_data.sh

This file was deleted.

0 comments on commit 63ea5dc

Please sign in to comment.